Closed
Bug 1030714
Opened 10 years ago
Closed 10 years ago
Clarify that unhandled rejections indicate an issue with the code
Categories
(Toolkit :: Async Tooling, defect)
Toolkit
Async Tooling
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: Paolo, Assigned: Paolo)
References
Details
Attachments
(2 files)
|
3.13 KB,
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
|
53.11 KB,
image/png
|
Details |
Screenshot
It seems that our reporting of unhandled rejections does not make it clear that there is problem with the code, and it may seem that they are the normal way to report rejections.
I tweaked the message to be more informative and, like mach errors, suggest solutions in the message itself. I also moved the hyperlink near the description.
See bug 911636 comment 32 for an example.
Attachment #8446491 -
Flags: review?(dteller)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8446491 [details] [diff] [review]
Mach-style error message
Review of attachment 8446491 [details] [diff] [review]:
-----------------------------------------------------------------
Good idea.
Attachment #8446491 -
Flags: review?(dteller) → review+
|
Assignee | |
Comment 2•10 years ago
|
||
Here is how the new message looks like.
|
|
Assignee | |
Comment 3•10 years ago
|
||
|
||
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•