Clarify that unhandled rejections indicate an issue with the code

RESOLVED FIXED in mozilla33

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Paolo, Assigned: Paolo)

Tracking

Trunk
mozilla33
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
Created attachment 8446491 [details] [diff] [review]
Mach-style error message

It seems that our reporting of unhandled rejections does not make it clear that there is problem with the code, and it may seem that they are the normal way to report rejections.

I tweaked the message to be more informative and, like mach errors, suggest solutions in the message itself. I also moved the hyperlink near the description.

See bug 911636 comment 32 for an example.
Attachment #8446491 - Flags: review?(dteller)
Comment on attachment 8446491 [details] [diff] [review]
Mach-style error message

Review of attachment 8446491 [details] [diff] [review]:
-----------------------------------------------------------------

Good idea.
Attachment #8446491 - Flags: review?(dteller) → review+
(Assignee)

Comment 2

4 years ago
Created attachment 8446494 [details]
Screenshot

Here is how the new message looks like.
https://hg.mozilla.org/mozilla-central/rev/20c6da8deb2b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.