Fix running jstests from the command line

NEW
Assigned to

Status

()

4 years ago
4 years ago

People

(Reporter: wingo, Assigned: wingo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Since bug 1029059, jstests no longer work from the command line.  The attached patch fixes it.
(Assignee)

Comment 1

4 years ago
Created attachment 8446505 [details] [diff] [review]
Fix running jstests from the command line
(Assignee)

Updated

4 years ago
Assignee: nobody → wingo
(Assignee)

Updated

4 years ago
Attachment #8446505 - Flags: review?(jorendorff)
Does this exhibit the same behavior for all the tests that test XPCOMABI?
Flags: needinfo?(wingo)
(I backed out bug 1029059 on inbound, but I wouldn't object to being able to check the target in a much cleaner way in jstests, which is what this patch does.)
(Assignee)

Comment 4

4 years ago
(In reply to Nathan Froyd (:froydnj) from comment #2)
> Does this exhibit the same behavior for all the tests that test XPCOMABI?

I believe so.  If you grep the tests for ABI you'll find that the only check that's made is match(/x86_64/), which this patch preserves.
Flags: needinfo?(wingo)
Comment on attachment 8446505 [details] [diff] [review]
Fix running jstests from the command line

Review of attachment 8446505 [details] [diff] [review]:
-----------------------------------------------------------------

Clearing review.

The offending patch was apparently backed out. It looks like this would be the right change though, so r=me if it recurs!
Attachment #8446505 - Flags: review?(jorendorff)

Updated

4 years ago
Duplicate of this bug: 1030724
You need to log in before you can comment on or make changes to this bug.