Open
Bug 1030815
Opened 10 years ago
Updated 2 years ago
Remove dangerous --disable-<feature> mozconfig options
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
NEW
People
(Reporter: Irving, Unassigned)
Details
Attachments
(1 file)
2.30 KB,
text/plain
|
Details |
I just spent a bunch of time helping someone in #introduction, and it turned out that the problem was that they had added a bunch of --disable-thing flags to their .mozconfig in the hope of speeding up their build.
While I haven't done an exhaustive check, in particular --disable-ctypes results in a completely broken browser, because OS.File depends on it.
Comment 1•10 years ago
|
||
We've done this in the past (bug 513924, bug 516758). I fully support removing footguns from the build system.
Comment 2•10 years ago
|
||
A lot of footguns you can find in attached .mozconfig file. Maybe it helps to anybody.
Comment 3•10 years ago
|
||
# Do not add this flags
#ac_add_options --disable-permissions #error LNK2019: unresolved external symbol "public: static void __cdecl nsPermissionManager::AppClearDataObserverInit"
#ac_add_options --disable-webrtc #error LNK2019: unresolved external symbol _I444ToI420
#ac_add_options --disable-cookies #fatal error C1083: Cannot open include file: 'mozilla/net/CookieServiceParent.h'
#ac_add_options --disable-accessibility #fatal error C1083: Cannot open include file: 'mozilla/a11y/Accessible.h'
#ac_add_options --disable-opus #fatal error C1083: Cannot open include file: 'opus/opus.h'
#ac_add_options --disable-feeds
#ac_add_options --disable-zipwriter #fatal error C1083: Cannot open include file: 'nsIZipWriter.h'
#ac_add_options --disable-webm #fatal error C1083: Cannot open include file: 'vpx/vpx_integer.h'
The sad thing is that some of these are legitimate to do, and should be filed as bugs.
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•