1030838 - Use the Contacts API for erasing contacts

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: FindMyDevice, defect)

Description

[Guilherme Gonçalves [:ggp]]

We used to rely on factoryReset erasing contacts, but it looks like that doesn't work on Flame: https://bugzilla.mozilla.org/show_bug.cgi?id=1028943#c3. We should do it properly and use ContactManager.clear(), instead.

https://developer.mozilla.org/en-US/docs/Web/API/ContactManager.clear

Comment 1

[Erin Lancaster [:elan]]

This feels non-trivial. We'll get an assignee in the next ~24 hours.

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Hey Doug - can we rely on the factory reset method here? I think we rely on it for SMS deletion already.

Comment 3

[Jason Smith [:jsmith]]

I'll + this because we need this for the FMD use case, but we need a separate bug on file for factory reset itself not working correctly.

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

(In reply to Jason Smith [:jsmith] from comment #3)
> I'll + this because we need this for the FMD use case, but we need a
> separate bug on file for factory reset itself not working correctly.

Yeah, very good point, Jason. If we knew factory reset worked reliably cross-device, we could close out this bug and bug 1032565 as well. Maybe that's the better approach?

Comment 5

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Actually, bug 1032565 has been backlogged for 2.0. Maybe we should do the same thing here?

Comment 6

[Jason Smith [:jsmith]]

(In reply to Jared Hirsch [:_6a68] [@6a68] from comment #5)
> Actually, bug 1032565 has been backlogged for 2.0. Maybe we should do the
> same thing here?

bug 1032565 was backlogged because it was speculative whether it was a problem that an end user could hit, where as this bug was confirmed to be a problem from QA testing.

Comment 7

[Jason Smith [:jsmith]]

(In reply to Jared Hirsch [:_6a68] [@6a68] from comment #4)
> (In reply to Jason Smith [:jsmith] from comment #3)
> > I'll + this because we need this for the FMD use case, but we need a
> > separate bug on file for factory reset itself not working correctly.
> 
> Yeah, very good point, Jason. If we knew factory reset worked reliably
> cross-device, we could close out this bug and bug 1032565 as well. Maybe
> that's the better approach?

I think that would be better approach - let's fix the root cause in factory reset itself. If factory reset isn't doing wiping data correctly, then that's a blocker we need to fix.

Comment 8

[Guilherme Gonçalves [:ggp]]

:dhylands and :gerard-majax just confirmed over IRC that factory reset is indeed guaranteed to erase both contacts and sms messages, so we don't need this.