Closed
Bug 1030894
Opened 12 years ago
Closed 12 years ago
Stop abusing nsAutoPtr in gfxFT2FontList.cpp
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(1 file)
|
1.61 KB,
patch
|
jfkthame
:
review+
jwatt
:
checkin+
|
Details | Diff | Splinter Review |
Right now this code works because our |operator delete| calls through to moz_free. We shouldn't rely on that though.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8446686 -
Flags: review?(jfkthame)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8446686 [details] [diff] [review]
patch
Review of attachment 8446686 [details] [diff] [review]:
-----------------------------------------------------------------
Ugh, yes, that looks broken. Thanks for catching it before anything blew up!
Attachment #8446686 -
Flags: review?(jfkthame) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Comment on attachment 8446686 [details] [diff] [review]
patch
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d43da9f5a03
Attachment #8446686 -
Flags: checkin+
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•