1030905 - write missing Input API tests

Status: RESOLVED FIXED

(Input Graveyard :: Code Quality, defect)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

I recently added a GET API for Input feedback. I wrote tests for many of the parameters, but there's a FIXME in the code listing the parameters that have no tests.

The code being tested is in fjord/feedback/api_views.py.

The tests are in fjord/feedback/tests/test_api.py.

This bug covers writing tests for the following parameters:

* date_start
* date_end
* delta
* product/version combination

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Making this a mentored bug.

This involves writing the specified tests that are missing. It's probably the case that you can cut and paste existing test code with some changes to test the new parameters.

It's possible that the code being tested is broken. If you think that's the case, let me know.

If you're interested in working on this bug, either reply in this bug's comments or ping me on IRC (I'm willkg).

Comment 2

[Ian Kronquist (:muricula)]

PR submitted on github: https://github.com/mozilla/fjord/pull/319

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

PR 319 landed in master in: https://github.com/mozilla/fjord/commit/e4c7c6c5

Still outstanding:

* product/version combination

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Added the outstanding tests in https://github.com/mozilla/fjord/commit/4887c49d

Since this is specific to the tests and no other changes were made, I'm marking this as FIXED.