1030913 - Add Favicons so easier to identify tabs

Status: RESOLVED FIXED

(bugzilla.mozilla.org Graveyard :: Bugzilla Anthropology Metrics, defect)

Description

[Kyle Lahnakoski [:ekyle]]

[lmandel] One request: I have the dashboards set as pinned tabs in my browser. As they don't have favicons, all of them show as grey boxes. Can we add some favicons to the dashboards? (Even just the letters B = Blocker, N = Nom, R = Regression, T= Team, and F = Feature would be useful.)

Comment 1

[Kyle Lahnakoski [:ekyle]]

Dear new contributor:

Working on charts.mozilla.org has the benefit of being highly visible to Mozilla.  When you contribute here, you are helping the FxOS team build a high quality product.  FxOS is part of Mozilla's strategy to keep the web open and promote the Mozilla Mission (https://www.mozilla.org/en-US/mission/).  

If you are an artist, or enjoy working on front end web and javascript, then this project would seriously benefit from your help.

For this bug, the image at fxos/images/fxos.ico needs to be copied to the main directory where it will be recognized by browsers and site-wide icon.  To do this: Make a fork of the code, make changes, then send a pull request.

Production:
> http://charts.mozilla.org/
Code:
> https://github.com/mozilla/charts
Docs:
> https://wiki.mozilla.org/Auto-tools/Projects/Charts
More on Good First Bugs:
> https://developer.mozilla.org/en/docs/Introduction

You can contact me on irc at [e-mail]; and you can find me in the #ateam channel with the rest of my team.

Comment 2

[jensonk9]

Hey ekyle,
Can I take this bug?
I am very new to this area, but I can do it with your support.

Looking forward to hear back from you. :)

Comment 3

[Kyle Lahnakoski [:ekyle]]

Yes please!  The bug is now yours!  I am on IRC (as [e-mail]), and #ateam channel.

Comment 4

[Kyle Lahnakoski [:ekyle]]

I saw your diff at https://github.com/jensonk9/charts/commit/285d1a4cf0ca3498e2d6b612ab130af528302180, it looks good.  Please send a pull request so I may review it formally.

Comment 5

[Kyle Lahnakoski [:ekyle]]

https://github.com/mozilla/charts/pull/24 has been merged to the Development branch!  I am keeping this bug open until it gets deployed in either staging or production.

Comment 6

[Kyle Lahnakoski [:ekyle]]

Since it looks like the dev branch will be a while before it merges with master, I decided to rebase jensonk9's patch to master: https://github.com/mozilla/charts/commit/a0fab456ae4c738f643798a3584ab008bed7b9ce

http://matthew-brett.github.io/pydagogue/rebase_without_tears.html

It should be up by the end of the day

Comment 7

[Kyle Lahnakoski [:ekyle]]

These changes are now up in production, but it appears I failed to notice the pinned tabs exclusively use the icons!  I have noticed FF has always been bad at using favicons properly; so they still do not show.  The icon does show in Chrome (pinned, or not).  

The next step is to make themed icons, like lmandel requested.

Comment 8

[Emuolanari]

Hi can i

Comment 9

[Emuolanari]

Hi, please can I be assigned to this project

Comment 10

[Kyle Lahnakoski [:ekyle]]

This bug is now yours!   Thank you!

You can find me as ekyle on #[e-mail] if you have questions.

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

resetting the assignedto field due to inactivity.  Kyle, can you confirm this bug is still useful and a good first bug?

Comment 12

[Kyle Lahnakoski [:ekyle]]

There are two bugs here now:  The work that was done, and the work still remaining.   I will come back to this bug and decide to either split it, close it, or make it a meta bug.

Comment 13

[Kyle Lahnakoski [:ekyle]]

We will call this fixed because the blocker bug 1014275 covers what needs to be done