1030917 - xpc::GlobalProperties object ignores the 'aPromise' param.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: sandbox.patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8446707 [details] [diff] [review]
sandbox.patch

Why is the right fix not to get rid of the argument?

Comment 3

[Andrea Marchesini [:baku]]

> Why is the right fix not to get rid of the argument?

Because somehow we call it with 'false' here:
https://mxr.mozilla.org/mozilla-central/source/js/xpconnect/src/XPCComponents.cpp#2784
And maybe that is wrong, but I don't know this code enough.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Right, and your patch would change the behavior of that callsite.  It's not obvious to me which behavior is correct, hence the review redirection to bholley.  ;)

Comment 5

[Bobby Holley (:bholley)]

Comment on attachment 8446707 [details] [diff] [review]
sandbox.patch

Review of attachment 8446707 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, it looks like this bool param in the constructor was an unreviewed post-r+ change from bug 988122. Let's remove it.

Comment 6

[Andrea Marchesini [:baku]]

Attachment: sandbox.patch

Comment 7

[Bobby Holley (:bholley)]

Comment on attachment 8448566 [details] [diff] [review]
sandbox.patch

Review of attachment 8448566 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that.

::: js/xpconnect/src/xpcprivate.h
@@ +3306,2 @@
>        mozilla::PodZero(this);
>        Promise = true;

Add a comment here indicating that this is because Promise is supposed to be part of ES, and therefore should appear on every global.

Comment 8

[Andrea Marchesini [:baku]]

https://tbpl.mozilla.org/?tree=Try&rev=7f46de59c54b

pushed to try before landing it.

Comment 9

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/381894d247b3

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/381894d247b3