1031030 - [Messages] URI schemes supported are inconsistent with browser: sms is not supported

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

1. tap rocketbar
2. type sms:2452453453

Expected: sms app launches a compose message to 2452453453
Actual: searches via the selected search engine "sms:2452453453"

Note:
1. same thing happens for tel
2. mailto: launches email

Gaia      6a1373340b40fcfe901336bc9e80676e5f2ba979
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/82ef9bf64d87
BuildID   20140626000202
Version   32.0a2
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
Flame

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Noming 2.0? based on bug 1032577 being fixed for 2.1

Comment 2

[Ben Francis [:benfrancis]]

I think this is actually consistent with the browser app, which will also do a search if you manually type in a tel: or sms: URL.

This seems like more of a feature request than a bug, "As a user I'd like to type a tel: or sms: URL into the Rocketbar/URL bar in order to call or send a text message to a phone number".

That doesn't seem like a hugely important use case as I'm guessing people would normally click on a tel: or sms: URL rather than type it. I am curious why we match mailto: as a URL and not tel: or sms: but I'm not convinced this should block the 2.0 release.

Comment 3

[Dale Harvey (:daleharvey)]

> I think this is actually consistent with the browser app, which will also do a search if you manually type in a tel: or sms: URL.

Not sure how you see that, I see the same as Naoki and the relative applications launch, it is a 'regression', But agreed it definitely shouldnt be a blocker, its a niche use case, as was data:, mailto: is supported since it registers itself as a handler for mailto: urls, 

Julien how do you feel about adding support for launching the dialer / sms app via tel:123 urls, It seems like it would mostly just be registering an activity and pretty much the same code that is used for the current activity handling, we can detect the urls in the search app and manually invoke the activities they currently support, but it seems far cleaner to have the relative applications to contain that logic.

Comment 4

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

I don't know how I can register a URL handler but otherwise, yep, this sounds a good idea.

Comment 5

[Dale Harvey (:daleharvey)]

Its not a url handler (although thats done with navigator.registerProtocolHandler), its an activity that listens for a view type=url with a regex

    "view": {
      "filters": {
        "type": "url",
        "url": { "required":true, "pattern":"mailto:.{1,16384}" },
        "disposition": "window",
        "returnValue": true
      }
    }

Is the email one, 

    "view": {
      "filters": {
        "type": "url",
        "url": {
          "required":true, "pattern":"(https?:|data:).{1,16384}", "patternFlags":"i"
        }
      }
    },

is the browser one

Comment 6

[Peter Dolanjski [:pdol]]

I'm not too worried that we don't have this in Rocketbar right now, as stated above.  Let's consider this functionality for the future as it is a pretty isolated use case.

Comment 7

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

Wilfred, would be nice to have this in v2.1, wdyt? Shouldn't be too hard.

Comment 8

[Anthony Ricaud (:rik)]

What happens if a user taps on <a href="tel:12345" /> or <a href="sms:12345" /> in the browser? And in an app? If that opens Dialer and SMS, then I don't think this is a 2.1 feature.

Comment 9

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

Let's see if a contributor would like to take this :)

Comment 10

[nils]

This seems to be resolved in recent v3.0 builds already. At least I could not reproduce it, sms:324234986 as well as tel:125125 start the corresponding apps (messages, dialer).

Comment 11

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

I agree !

I see an issue though: when doing this from the homescreen and canceling the activity (pressing the cross button), we're left in a blank screen.

I'll close this bug, but I think a new bug should be filed for the new issue. Could you do that Nils ? This should be filed in Gaia::System::Window Manager.

Comment 12

[nils]

Sure, over here: https://bugzilla.mozilla.org/show_bug.cgi?id=1182870

Comment 13

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

Thanks !

Comment 14

[André Fiedler]

Great, thx nils! :)