mach environment duplicates logic from MachCommandBase

RESOLVED FIXED in Firefox -esr31, Firefox OS v2.0

Status

()

Core
Build Config
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Blocks: 1 bug)

unspecified
mozilla33
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr31 fixed, b2g-v2.0 fixed, b2g-v2.0M fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
When mach environment was written, MachCommandBase didn't exist. Now, the checks in mach environment are redundant with what MachCommandBase does. However, its error handling for ObjdirMismatchException is better than that of MachCommandBase.
(Assignee)

Comment 1

4 years ago
Created attachment 8446950 [details] [diff] [review]
Refactor mach environment to use logic from MachCommandBase instead of its own

Also don't print section titles when there is nothing under them, and move
move the ObjdirMismatchException handling to MachCommandBase.
Attachment #8446950 - Flags: review?(gps)
(Assignee)

Comment 2

4 years ago
Created attachment 8446951 [details] [diff] [review]
Refactor mach environment to use logic from MachCommandBase instead of its own

mozconfig path was missing.
Attachment #8446951 - Flags: review?(gps)
(Assignee)

Updated

4 years ago
Attachment #8446950 - Attachment is obsolete: true
Attachment #8446950 - Flags: review?(gps)
(Assignee)

Updated

4 years ago
Blocks: 762358

Comment 3

4 years ago
Comment on attachment 8446951 [details] [diff] [review]
Refactor mach environment to use logic from MachCommandBase instead of its own

Review of attachment 8446951 [details] [diff] [review]:
-----------------------------------------------------------------

More unified code. W00t.
Attachment #8446951 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/3ee4eaf0c38e
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33

Updated

3 years ago
status-firefox-esr31: --- → fixed

Updated

3 years ago
status-b2g-v2.0: --- → fixed

Updated

3 years ago
Blocks: 1054172
You need to log in before you can comment on or make changes to this bug.