Closed Bug 1031132 Opened 6 years ago Closed 6 years ago

mach environment duplicates logic from MachCommandBase

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox-esr31 fixed, b2g-v2.0 fixed, b2g-v2.0M fixed)

RESOLVED FIXED
mozilla33
Tracking Status
firefox-esr31 --- fixed
b2g-v2.0 --- fixed
b2g-v2.0M --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file, 1 obsolete file)

When mach environment was written, MachCommandBase didn't exist. Now, the checks in mach environment are redundant with what MachCommandBase does. However, its error handling for ObjdirMismatchException is better than that of MachCommandBase.
Also don't print section titles when there is nothing under them, and move
move the ObjdirMismatchException handling to MachCommandBase.
Attachment #8446950 - Flags: review?(gps)
mozconfig path was missing.
Attachment #8446951 - Flags: review?(gps)
Attachment #8446950 - Attachment is obsolete: true
Attachment #8446950 - Flags: review?(gps)
Blocks: 762358
Comment on attachment 8446951 [details] [diff] [review]
Refactor mach environment to use logic from MachCommandBase instead of its own

Review of attachment 8446951 [details] [diff] [review]:
-----------------------------------------------------------------

More unified code. W00t.
Attachment #8446951 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/3ee4eaf0c38e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Blocks: Woodduck
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.