Closed Bug 1031167 Opened 11 years ago Closed 11 years ago

Fix non-unified OS X build's warnings-as-errors in tools/profiler

Categories

(Core :: Gecko Profiler, defect)

Product:
Core
Component:
Gecko Profiler
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla33
Tracking Flags:
Tracking Status
firefox32 --- wontfix
firefox33 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

fix-profiler-non-unified-build.patch
1.02 KB, patch
BenWa
: review+
Details | Diff | Splinter Review
When building with these mozconfig settings using clang on OS X: ac_add_options --disable-unified-compilation ac_add_options --enable-warnings-as-errors I hit the following warnings-as-error build error: > tools/profiler/platform-macos.cc:61:24: error: unused variable 'kNoThread' [-Werror,-Wunused-const-variable]
Attachment #8446992 - Flags: review?(bgirard)
Attachment #8446992 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/mozilla-central/rev/6a10ccabb63e
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: