1031196 - Improve Display for Profile Details Page

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: One and Done, defect)

Description

[Pankaj Malhotra (:bitgeeky)]

This bug is to improve the display of elements on profile details page.

Comment 1

[Pankaj Malhotra (:bitgeeky)]

Attachment: Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/143

This version of Profile Details page looks better.

Comment 2

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8447030 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/143

Looks good, bitgeeky. This is definitely an improvement. Please address the comments and re-flag me for review.

Comment 3

[Pankaj Malhotra (:bitgeeky)]

Comment on attachment 8447030 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/143

Made the suggested changes. Please review.

Comment 4

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8447030 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/143

Ready to merge. Just squash the commits please.

Comment 5

[Pankaj Malhotra (:bitgeeky)]

Squashed the commits. It can be merged now.

Comment 6

[Bob Silverberg [:bsilverberg]]

Landed in https://github.com/mozilla/oneanddone/commit/066458179cd6ce1f375357da45c526dc68f4999e

Comment 7

[Rebecca Billings [:rbillings]]

In the future it would be helpful to describe what the improvements are for testing.

Comment 8

[Rebecca Billings [:rbillings]]

Marking as verified as the profile details page looks good- but it is difficult to determine exactly what changed.