1031199 - disallow aWeight = 0 when calling gfxUserFontSet::AddFontFace

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Cameron McCormack (:heycam)]

Attachment: patch

I think it makes more sense to handle a 0 value for a font-weight descriptor in nsUserFontSet, where the mapping of descriptor nsCSSValues to arguments to pass to gfxUserFontSet::AddFontFace is done.  (This will let me avoid duplicating this logic in bug 1028497.)

Comment 1

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4be991cbf4a6

Comment 2

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4be991cbf4a6

Comment 3

[Cameron McCormack (:heycam)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/37683ae1953f

Comment 4

[Carsten Book [:Tomcat]]

sorry had to backout this changes in https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=0294fdaef9be since one of this changes caused test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=43424728&tree=Mozilla-Inbound

Comment 5

[Cameron McCormack (:heycam)]

Relanded: https://hg.mozilla.org/integration/mozilla-inbound/rev/b9c4f3960eb2

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b9c4f3960eb2