Closed Bug 1031199 Opened 5 years ago Closed 5 years ago

disallow aWeight = 0 when calling gfxUserFontSet::AddFontFace

Categories

(Core :: Graphics: Text, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
I think it makes more sense to handle a 0 value for a font-weight descriptor in nsUserFontSet, where the mapping of descriptor nsCSSValues to arguments to pass to gfxUserFontSet::AddFontFace is done.  (This will let me avoid duplicating this logic in bug 1028497.)
Attachment #8447032 - Flags: review?(jdaggett)
Attachment #8447032 - Flags: review?(jdaggett) → review+
https://hg.mozilla.org/mozilla-central/rev/4be991cbf4a6
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.