Closed
Bug 1031199
Opened 10 years ago
Closed 10 years ago
disallow aWeight = 0 when calling gfxUserFontSet::AddFontFace
Categories
(Core :: Graphics: Text, defect)
Core
Graphics: Text
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: heycam, Assigned: heycam)
References
Details
Attachments
(1 file)
|
3.18 KB,
patch
|
jtd
:
review+
|
Details | Diff | Splinter Review |
I think it makes more sense to handle a 0 value for a font-weight descriptor in nsUserFontSet, where the mapping of descriptor nsCSSValues to arguments to pass to gfxUserFontSet::AddFontFace is done. (This will let me avoid duplicating this logic in bug 1028497.)
Attachment #8447032 -
Flags: review?(jdaggett)
|
||
Updated•10 years ago
|
Attachment #8447032 -
Flags: review?(jdaggett) → review+
|
Assignee | |
Comment 1•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4be991cbf4a6
|
||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4be991cbf4a6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/37683ae1953f
|
|
||
Comment 4•10 years ago
|
||
sorry had to backout this changes in https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=0294fdaef9be since one of this changes caused test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=43424728&tree=Mozilla-Inbound
|
|
Assignee | |
Comment 5•10 years ago
|
||
Relanded: https://hg.mozilla.org/integration/mozilla-inbound/rev/b9c4f3960eb2
|
|
||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b9c4f3960eb2
You need to log in
before you can comment on or make changes to this bug.
Description
•