Closed
Bug 1031292
Opened 10 years ago
Closed 10 years ago
[geolocation] Map doesn't always center to result
Categories
(Participation Infrastructure :: Phonebook, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: giorgos, Assigned: wbowling)
Details
Steps to reproduce:
- Go to /user/edit
- Type 'athens' in search box. Select with mouse first result. Map moves, fields update
- Type 'surinam' in search box. Select with mouse first result. Map doesn't move, fields update.
Expected:
- Map should move
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(wbowling)
Assignee | ||
Comment 1•10 years ago
|
||
Uh oh... This is a bigger problem. Roads can be entered into the search and get false positive responses.
The first result for "Surinam" is this road
http://www.openstreetmap.org/way/230282749
Similarly, I can make the same bug occur if i type in the name of any road "i-40" or "A21" or "Autobahn" all result in the same bug. I'll see if there's some way to exclude roads in our results.
Flags: needinfo?(wbowling)
Assignee | ||
Comment 2•10 years ago
|
||
Bingo. We can simply filter out data that isn't a country, province, or city with the mapbox ID.
https://www.mapbox.com/developers/api/geocoding/
Comment 3•10 years ago
|
||
(In reply to Wray Bowling [:wbowling] from comment #2)
> Bingo. We can simply filter out data that isn't a country, province, or city
> with the mapbox ID.
Nice! Do you want to work on this bug, Wray?
Assignee | ||
Comment 4•10 years ago
|
||
Assignee: nobody → wbowling
Reporter | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Comment 5•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/mozillians
https://github.com/mozilla/mozillians/commit/4ac3dcc6151cc41fb2090cd9d101e73ebcc14149
[fix bug 1031292] Limit geocoding results to city, region and country.
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Version: other → next
Reporter | ||
Comment 6•10 years ago
|
||
I cannot reproduce anymore the problem described in comment #0 on stage. Marking this one verified/fixed.
Thanks :wbowling!
Status: RESOLVED → VERIFIED
Reporter | ||
Updated•10 years ago
|
Version: next → 2014-07.3
You need to log in
before you can comment on or make changes to this bug.
Description
•