1031310 - remove xpcom/analysis/ directory

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nathan Froyd [:froydnj]]

Dehydra is dead, and we have clang static analysis stuff to replace it.  No sense in keeping old code around, right?

Comment 1

[Benjamin Smedberg]

The only thing I'm sorta-attached to in that directory is the autogenerated XPCOM string docs. But since they were coded against dekiwiki (which we don't use anymore) and dehydra (which doesn't work any more) I guess it doesn't make sense to just keep them around out of wishful nostalgia.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: remove xpcom/analysis/

The type-printer.js file was even using E4X!

Comment 3

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/82c4c46374dd

Comment 4

[(no longer active)]

This directory was actually *very* useful as a placeholder for stuff that we want to add to the clang plugin.  Is there really much value in removing it? :(

Comment 5

[Nathan Froyd [:froydnj]]

(In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #4)
> This directory was actually *very* useful as a placeholder for stuff that we
> want to add to the clang plugin.  Is there really much value in removing it?
> :(

Is there really much value in keeping it around vs. filing bugs on the analyses we'd like to have?

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/82c4c46374dd

Comment 7

[(no longer active)]

(In reply to comment #5)
> (In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment
> #4)
> > This directory was actually *very* useful as a placeholder for stuff that we
> > want to add to the clang plugin.  Is there really much value in removing it?
> > :(
> 
> Is there really much value in keeping it around vs. filing bugs on the analyses
> we'd like to have?

Well, the latter is obviously much better!  :-)