1031328 - running testpkgs from outside the sdk dir broken

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Tomislav Jovanovic :zombie]

broken in bug 1024791. 

looks like unit tests are not packed into the test addon unless you run `cfx testpkgs` from the root of the sdk dir.

this worked before because cuddlefish/manifest.py scanned the root folder of the sdk [1], and passed that list via allTestModules, but that is now gone [2]

[1] https://github.com/mozilla/addon-sdk/blob/master/python-lib/cuddlefish/manifest.py#L219
[2] https://github.com/mozilla/addon-sdk/pull/1521/files#diff-9

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

I'm not sure that running testpkgs from outside the sdk dir was ever a supported use case.

Comment 2

[Tomislav Jovanovic :zombie]

all other cfx commands work from wherever you are, and running `cfx testpkgs` is basically equivalent to running `cfx test` from the sdk root dir, so it might as well be all the way equivalent.

i don't really care now that i know, but i really cared last night when i lost some hours trying to figure out what was happening.

or at least a warning message that might save someone else some time..

Comment 3

[Dave Townsend [:mossop]]

I'm not sure if it was ever supported either. I'd say we should accept a simple patch either to fix or warn but I don't care that much here.

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1546

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8454118 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1546

That easy? Awesome!

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/1894160be00768991ca99a4f6e090f716b246780
Bug 1031328 - running testpkgs from outside the sdk dir broken

https://github.com/mozilla/addon-sdk/commit/bf111135b282e556d555439db17172d04fb648d4
Merge pull request #1546 from erikvold/bug-1031328

Bug 1031328 - running testpkgs from outside the sdk dir broken r=@Mossop

Comment 7

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1548

This should fix the oranges.

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/e1e0ab7fb68037b9663ef0db01cafe8941489a31
Bug 1031328 overwrite modules when the test package is the sdk

https://github.com/mozilla/addon-sdk/commit/69be2b930c685bbb2272b6edcb326f7b751825b3
Merge pull request #1548 from erikvold/1031328p2

Bug 1031328 overwrite modules when the test package is the sdk r=gozala

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/e37ae367c3385c3dfa4ae9bdf5ebfdfbd831b807
Revert "Bug 1031328 overwrite modules when the test package is the sdk"

This reverts commit e1e0ab7fb68037b9663ef0db01cafe8941489a31.

https://github.com/mozilla/addon-sdk/commit/73b5af640f02deb547db8a093cf14fe1d95fb074
Revert "Bug 1031328 - running testpkgs from outside the sdk dir broken"

This reverts commit 1894160be00768991ca99a4f6e090f716b246780.

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/cf8176f9cdcbce45d4b90277ef62e9bde46107c5
Bug 1031328 - running testpkgs from outside the sdk dir broken r=@Mossop