Closed Bug 1031390 Opened 6 years ago Closed 6 years ago

Marionette busted on v2.0

Categories

(Testing :: Marionette, defect, major)

ARM
Gonk (Firefox OS)
defect
Not set
major

Tracking

(b2g-v2.0 fixed)

RESOLVED FIXED
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: nsarkar, Unassigned)

References

Details

(Keywords: pi-marionette-runner)

Attachments

(1 file)

Marionette currently only supports mozrunner 5.37 and latest pypi.python.org/simple/mozrunner’s version is 6.0.

This is causing incompatibility issues and marionette is not being set up at all. As a result, we are unable to run any tests.
Looks like the v2.0 version of Marionette can't handle mozrunner 6.0.   Locking to mozrunner 5.37 in v2.0 could be one option to fix:


diff --git a/testing/marionette/client/requirements.txt b/testing/marionette/client/requirements.txt
index 8188cf8..e13e6a8 100644
--- a/testing/marionette/client/requirements.txt
+++ b/testing/marionette/client/requirements.txt
@@ -2,7 +2,7 @@ manifestdestiny
 mozhttpd >= 0.5
 mozinfo >= 0.7
 mozprocess >= 0.9
-mozrunner >= 5.15
+mozrunner == 5.37
 mozdevice >= 0.22
 moznetwork >= 0.21
 mozcrash >= 0.5
Maybe a dup of bug 1028254?
Depends on: 994176
Summary: Marionette set up is busted. We are unable to run any tests at the moment. → Marionette busted on v2.0
Component: General → Marionette
Product: Firefox OS → Testing
We've already pinned mozrunner in v1.4, so we should just need to pin the version of mozrunner used in mozilla-aurora:

http://hg.mozilla.org/releases/mozilla-aurora/file/d4dc609bcc8a/testing/marionette/client/requirements.txt#l6

I'm cloning mozilla-aurora now and will prepare a patch.
Note, for running against v1.4 you should use https://pypi.python.org/pypi/marionette_client-mozilla-b2g30_v1_4

When I first read this I thought it was about builds failing in TBPL but now I'm not so sure. If we fix this in mozilla-aurora then we'd need another client in PyPI for running against this branch. I was hoping to avoid that (and wait for a 2.0 release branch).

The other option is to install mozrunner 5.37.1 before installing the marionette client, in which case the dependency is already met and 6.0 will not be installed.

Jonathan: We should still pin mozrunner in mozilla-aurora, but do you think we should create another PyPI package?

Nivi: Does installing mozrunner 5.37.1 first fix the issue for you?
Flags: needinfo?(nsarkar)
Flags: needinfo?(jgriffin)
Here's a patch to pin the mozrunner version. Another option is to uplift the mozrunner changes to mozilla-aurora, if it's safe to do that.
Attachment #8447882 - Flags: review?(jgriffin)
Comment on attachment 8447882 [details] [diff] [review]
Pin mozrunner to latest from branch. v1.0

Review of attachment 8447882 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8447882 - Flags: review?(jgriffin) → review+
Let's not uplift the mozrunner changes to mozilla-aurora, that's a higher-risk option.
Flags: needinfo?(jgriffin)
Yes installing mozrunner 5.37 fixes the issue. We have a temporary fix for v2.0. We hope you guys can fix this so we can get rid of our workaround.

Thanks,
Nivi.


(In reply to Dave Hunt (:davehunt) from comment #4)
> Note, for running against v1.4 you should use
> https://pypi.python.org/pypi/marionette_client-mozilla-b2g30_v1_4
> 
> When I first read this I thought it was about builds failing in TBPL but now
> I'm not so sure. If we fix this in mozilla-aurora then we'd need another
> client in PyPI for running against this branch. I was hoping to avoid that
> (and wait for a 2.0 release branch).
> 
> The other option is to install mozrunner 5.37.1 before installing the
> marionette client, in which case the dependency is already met and 6.0 will
> not be installed.
> 
> Jonathan: We should still pin mozrunner in mozilla-aurora, but do you think
> we should create another PyPI package?
> 
> Nivi: Does installing mozrunner 5.37.1 first fix the issue for you?
Flags: needinfo?(nsarkar)
Nivi, can you confirm this is fixed now?
Flags: needinfo?(nsarkar)
Hi Jonathan,

Thank you so much for the fix. It does work now.

Thanks,
Nivi.
Flags: needinfo?(nsarkar)
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.