Closed Bug 1031395 Opened 6 years ago Closed 6 years ago

Clang Static Analysis: Remove never read value to fix a minor warning found by scan-build.

Categories

(Core :: Layout, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: pmaddi, Assigned: pmaddi)

References

(Blocks 1 open bug)

Details

(Keywords: clang-analyzer)

Attachments

(1 file)

The attached patch fixes a warning detected by scan-build, the clang static analyzer.
No longer depends on: 1019722
Attachment #8447271 - Flags: review?(ehsan)
Comment on attachment 8447271 [details] [diff] [review]
0001-Remove-a-double-assignment-to-limit-to-fix-a-minor-w.patch

Review of attachment 8447271 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks a lot for your patch, Pranav!
Attachment #8447271 - Flags: review?(ehsan) → review+
Keywords: checkin-needed
Just for the record: a bit of hg blame / bonsai blame archeology shows that this dates back to the very first version of this code, added in bug 70394, back in 2001.

(It's in attachment 26583 [details], the third attachment on that bug; this same code is at the beginning of nsBidi::GetRuns() in that file.)
Blocks: 70394
Version: unspecified → Trunk
Daniel, that's pretty neat :)
https://hg.mozilla.org/mozilla-central/rev/5ad7b9998d78
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.