Closed Bug 103148 Opened 23 years ago Closed 23 years ago

Active Accessibility: turn off XUL accessibliity when not needed

Categories

(Core :: XUL, defect, P2)

x86
Windows 2000
defect

Tracking

()

RESOLVED FIXED
mozilla0.9.8

People

(Reporter: mozilla, Assigned: mozilla)

References

Details

(Keywords: access)

Attachments

(3 files, 6 obsolete files)

see bug 69995 for the discussion about the #ifdef MOZ_XUL

Use MOZ_XUL to turn off the compilation of XUL accessiblity files.
Status: NEW → ASSIGNED
Depends on: 102777
Keywords: access
Priority: -- → P3
Target Milestone: --- → mozilla1.0
Priority: P3 → P2
Target Milestone: mozilla1.0 → mozilla0.9.7
cls, can we move to make NO_XUL part of the "embed" build?
If you're going to make the "embed" build a special build with its own bloat
trimming defines instead of just a subset of our current build, then yes.  If
we're going to stick with "embed's a subset of a stock build" approach, then xul
will have to be broken out into its own set of libs.
Summary: turn off XUL accessibliity when not needed → Active Accessibility: turn off XUL accessibliity when not needed
Attached patch first crack (obsolete) — Splinter Review
This patch contains all the directory division stuff, including new
makefile.wins and Makefile.ins. It does not contain the removal of all the
files in the src directory though (have to find a way to do that using a
script)

it also does not contain the switch(makefile #define) to turn off compilation
of XUL accessibility, although that is really easy -- just forgot that part.
:-)
Attached patch diff of makefiles (obsolete) — Splinter Review
This contains the changes to the makefile.in and makefile.win in accessible/src
and in accessible/build and the new makefile.in and makefile.win for each of
the new directories ( base, xul and html ).
Attached patch makefile diff take 2 (obsolete) — Splinter Review
Fixed a bunch of unix makefile stuff and added a change to autoconf.mk.in
Attachment #59620 - Attachment is obsolete: true
adding a dependancy on a bug tracking the split of accessible/src into 3
seperate dirs.

To get this switch working we need the following:
- change to autoconf.mk.in to give makefiles access to MOZ_XUL
- add ifdefs to makefiles
- ifdef the XUL specific code in the base dir so it won't choke without the XUL
library
- I think we will need something in the mac environment to turn on/off the
building of the XUL dir, maybe in MozBuildList.pm as well as defining the
variable MOZ_XUL ( I don't see it in there yet )
Depends on: 112701
jgaunt, akk this script should do the moves you want. I didn't compare the file
lists you sent me, so correct me if there should be file renames in addition to
moves that i missed.

I'll start reviewing the makefile changes now. has someone tested them on mac,
windows, and linux?
The filenames in your attachment look fine. What am I supposed to do with it? I
was under the impression that this was something that happend on your end? ( or
are you just posted it for my confirmation ).

Yes, I have test-moved the files on win mac and linux and adjusted the makefiles
and mcp and MozillaBuildList.pm files accordingly.
yeah, just posted what i'm going to do for confirmation. I'll go ahead and do
the copy now. Do i need to lock it down, or are people working on accessibility
waiting on this?
Comment on attachment 59725 [details] [diff] [review]
 makefile diff take 2

looks good to me, and the files have been copied to the new location. please
cvs remove the old file locations when you've done the build changes.
Attachment #59725 - Flags: review+
Attached patch makefiles, AccService.... (obsolete) — Splinter Review
This has the linux and windows stuff to turn off xul acc. 

Final patch will also have the removal of all the files in accessible/src (
except the makefiles and dirs of course )
Attachment #59456 - Attachment is obsolete: true
Attachment #59725 - Attachment is obsolete: true
Attached patch Cleaned up diffSplinter Review
This contains the cvsignore files for the new directories, additions to
allmakefiles.sh and the moz_xul work, plus all the file removals. The only
changes are at the beginning and ending of the diff, excepting one .cvsignore
file. Everything else in the file is the removal of filed from accessible/src
Attachment #60448 - Attachment is obsolete: true
r=aaronl
Whiteboard: almost there, getting mac stuff complete
Attached patch mac file changes (obsolete) — Splinter Review
Here are changes to MozillaBuildList.txt and MozillaBuildFlags.txt. There are
also changes to the accessible.mcp and a new accessible_xul.mcp file ready to
go in.
Attached patch update mac file changes (obsolete) — Splinter Review
contains the full files for the new mac build system, namely the xml based mcp
files. Both the updated version of the old one and the entirely new
accessible_xul mcp file. Since the change hasn't landed yet I was unable to
post a diff of the existing file.
Attachment #61126 - Attachment is obsolete: true
Target Milestone: mozilla0.9.7 → mozilla0.9.8
this contains the buildlist and buildflag changes as well as a diff for the mac
mcp xml file for accessible.xml. I did not include accessible_xul.xml since it
is several thousand lines long, but suffice to say it contains all the
nsXULfooAccessible.cpp files.
Attachment #61135 - Attachment is obsolete: true
Whiteboard: almost there, getting mac stuff complete
Unified diffs next time please (set in MacCVS Pro preferences)! Mac build changes 
look OK to me.
Whiteboard: needs sr
sr=hyatt
Whiteboard: needs sr → ready
checked in 
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: ready
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: