Closed
Bug 103148
Opened 23 years ago
Closed 23 years ago
Active Accessibility: turn off XUL accessibliity when not needed
Categories
(Core :: XUL, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla0.9.8
People
(Reporter: mozilla, Assigned: mozilla)
References
Details
(Keywords: access)
Attachments
(3 files, 6 obsolete files)
639 bytes,
text/plain
|
Details | |
367.85 KB,
patch
|
netscape
:
review+
|
Details | Diff | Splinter Review |
12.44 KB,
patch
|
Details | Diff | Splinter Review |
see bug 69995 for the discussion about the #ifdef MOZ_XUL Use MOZ_XUL to turn off the compilation of XUL accessiblity files.
Assignee | ||
Updated•23 years ago
|
Updated•23 years ago
|
Priority: P3 → P2
Target Milestone: mozilla1.0 → mozilla0.9.7
Comment 1•23 years ago
|
||
cls, can we move to make NO_XUL part of the "embed" build?
Comment 2•23 years ago
|
||
If you're going to make the "embed" build a special build with its own bloat trimming defines instead of just a subset of our current build, then yes. If we're going to stick with "embed's a subset of a stock build" approach, then xul will have to be broken out into its own set of libs.
Updated•23 years ago
|
Summary: turn off XUL accessibliity when not needed → Active Accessibility: turn off XUL accessibliity when not needed
Assignee | ||
Comment 3•23 years ago
|
||
This patch contains all the directory division stuff, including new makefile.wins and Makefile.ins. It does not contain the removal of all the files in the src directory though (have to find a way to do that using a script) it also does not contain the switch(makefile #define) to turn off compilation of XUL accessibility, although that is really easy -- just forgot that part. :-)
Assignee | ||
Comment 4•23 years ago
|
||
This contains the changes to the makefile.in and makefile.win in accessible/src and in accessible/build and the new makefile.in and makefile.win for each of the new directories ( base, xul and html ).
Assignee | ||
Comment 5•23 years ago
|
||
Fixed a bunch of unix makefile stuff and added a change to autoconf.mk.in
Attachment #59620 -
Attachment is obsolete: true
Assignee | ||
Comment 6•23 years ago
|
||
adding a dependancy on a bug tracking the split of accessible/src into 3 seperate dirs. To get this switch working we need the following: - change to autoconf.mk.in to give makefiles access to MOZ_XUL - add ifdefs to makefiles - ifdef the XUL specific code in the base dir so it won't choke without the XUL library - I think we will need something in the mac environment to turn on/off the building of the XUL dir, maybe in MozBuildList.pm as well as defining the variable MOZ_XUL ( I don't see it in there yet )
Depends on: 112701
Comment 7•23 years ago
|
||
jgaunt, akk this script should do the moves you want. I didn't compare the file lists you sent me, so correct me if there should be file renames in addition to moves that i missed. I'll start reviewing the makefile changes now. has someone tested them on mac, windows, and linux?
Assignee | ||
Comment 8•23 years ago
|
||
The filenames in your attachment look fine. What am I supposed to do with it? I was under the impression that this was something that happend on your end? ( or are you just posted it for my confirmation ). Yes, I have test-moved the files on win mac and linux and adjusted the makefiles and mcp and MozillaBuildList.pm files accordingly.
Comment 9•23 years ago
|
||
yeah, just posted what i'm going to do for confirmation. I'll go ahead and do the copy now. Do i need to lock it down, or are people working on accessibility waiting on this?
Comment 10•23 years ago
|
||
Comment on attachment 59725 [details] [diff] [review] makefile diff take 2 looks good to me, and the files have been copied to the new location. please cvs remove the old file locations when you've done the build changes.
Attachment #59725 -
Flags: review+
Assignee | ||
Comment 11•23 years ago
|
||
This has the linux and windows stuff to turn off xul acc. Final patch will also have the removal of all the files in accessible/src ( except the makefiles and dirs of course )
Attachment #59456 -
Attachment is obsolete: true
Attachment #59725 -
Attachment is obsolete: true
Assignee | ||
Comment 12•23 years ago
|
||
This contains the cvsignore files for the new directories, additions to allmakefiles.sh and the moz_xul work, plus all the file removals. The only changes are at the beginning and ending of the diff, excepting one .cvsignore file. Everything else in the file is the removal of filed from accessible/src
Attachment #60448 -
Attachment is obsolete: true
Comment 13•23 years ago
|
||
Comment on attachment 60567 [details] [diff] [review] Cleaned up diff r=cls
Attachment #60567 -
Flags: review+
Comment 14•23 years ago
|
||
r=aaronl
Assignee | ||
Updated•23 years ago
|
Whiteboard: almost there, getting mac stuff complete
Assignee | ||
Comment 15•23 years ago
|
||
Here are changes to MozillaBuildList.txt and MozillaBuildFlags.txt. There are also changes to the accessible.mcp and a new accessible_xul.mcp file ready to go in.
Assignee | ||
Comment 16•23 years ago
|
||
contains the full files for the new mac build system, namely the xml based mcp files. Both the updated version of the old one and the entirely new accessible_xul mcp file. Since the change hasn't landed yet I was unable to post a diff of the existing file.
Attachment #61126 -
Attachment is obsolete: true
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.7 → mozilla0.9.8
Assignee | ||
Comment 17•23 years ago
|
||
this contains the buildlist and buildflag changes as well as a diff for the mac mcp xml file for accessible.xml. I did not include accessible_xul.xml since it is several thousand lines long, but suffice to say it contains all the nsXULfooAccessible.cpp files.
Attachment #61135 -
Attachment is obsolete: true
Assignee | ||
Updated•23 years ago
|
Whiteboard: almost there, getting mac stuff complete
Comment 18•23 years ago
|
||
Unified diffs next time please (set in MacCVS Pro preferences)! Mac build changes look OK to me.
Assignee | ||
Updated•23 years ago
|
Whiteboard: needs sr
Comment 19•23 years ago
|
||
sr=hyatt
Assignee | ||
Updated•23 years ago
|
Whiteboard: needs sr → ready
Assignee | ||
Comment 20•23 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: ready
You need to log in
before you can comment on or make changes to this bug.
Description
•