Closed
Bug 1031482
Opened 10 years ago
Closed 10 years ago
Restore Label's asserts
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: sunfish, Assigned: sunfish)
References
Details
Attachments
(1 file)
2.55 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Bug 976446 moved LabelBase, Label, and NonAssertingLabel into their own header file, but dropped the Label class' assert -- the assert that NonAssertingLabel exists to suppress. Attached is a patch to restore the assert. If this isn't desired, we should delete the NonAssertingLabel class.
Attachment #8447369 -
Flags: review?(jdemooij)
Comment 1•10 years ago
|
||
Comment on attachment 8447369 [details] [diff] [review] label-asserts.patch Review of attachment 8447369 [details] [diff] [review]: ----------------------------------------------------------------- Good catch. I didn't notice the asserts being removed as part of the move.. ::: js/src/jit/Label.h @@ +6,5 @@ > > #ifndef jit_Label_h > #define jit_Label_h > > +#include "jit/Ion.h" Hm isn't this a cyclic include? @@ +82,5 @@ > +#ifdef DEBUG > + // The assertion below doesn't hold if an error occurred. > + if (OOM_counter > OOM_maxAllocations) > + return; > + if (IonContext *context = MaybeGetIonContext()) Nit: add {}
Attachment #8447369 -
Flags: review?(jdemooij) → review+
Comment 2•10 years ago
|
||
(In reply to Jan de Mooij [:jandem] from comment #1) > Hm isn't this a cyclic include? I thought Ion.h had more #includes but it's not too bad. Nevermind.
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5cf6f6dfa83
https://hg.mozilla.org/mozilla-central/rev/b5cf6f6dfa83
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•