MPL for Java (part of Fennec), PD for test-only code. https://github.com/mozilla-services/android-sync/blob/develop/tools/COPYRIGHT_MPL https://github.com/mozilla-services/android-sync/blob/develop/tools/COPYRIGHT_PD
Created attachment 8447420 [details] [diff] [review] bug-1031534-fix.patch The patch is queued as a pull request: https://github.com/ericedens/FirefoxSearch/pull/12/files
Also, here's a quick Python script to check whether files are missing the license: import os files = [os.path.join(dp, f) for dp, dn, fn in os.walk(os.path.expanduser("FirefoxSearch")) for f in fn] for fname in files: if '.git' in fname: continue if '.idea' in fname: continue if 'geckoView' in fname: continue with open(fname) as f: if 'MPL' not in f.read(): print fname
Created attachment 8447435 [details] [diff] [review] bug-1031534-fix.patch Fixed commenting style
Created attachment 8447442 [details] [diff] [review] bug-1031534-fix.patch
This patch never landed, did it? Eric, typical practice is to resolve bugs once the patch lands on mozilla-central.
Hi Ryan, on this project, for the moment, we're committing changes through a GitHub repo , and then pushing to M-C as a separate workflow . So this particular patch was landed through that pull request. 1. https://github.com/ericedens/FirefoxSearch/pull/12/files 2. https://bugzilla.mozilla.org/show_bug.cgi?id=1021864
Fair enough. In the future, it's always good form to post changeset links to wherever you committed the patch to, though.