If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

License fragment headers throughout

RESOLVED FIXED

Status

()

Firefox for Android
Search Activity
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: eedens, Assigned: eedens)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

3 years ago
MPL for Java (part of Fennec), PD for test-only code.

https://github.com/mozilla-services/android-sync/blob/develop/tools/COPYRIGHT_MPL
https://github.com/mozilla-services/android-sync/blob/develop/tools/COPYRIGHT_PD
(Assignee)

Comment 1

3 years ago
Created attachment 8447420 [details] [diff] [review]
bug-1031534-fix.patch

The patch is queued as a pull request: https://github.com/ericedens/FirefoxSearch/pull/12/files
Attachment #8447420 - Flags: review?(nalexander)
(Assignee)

Comment 2

3 years ago
Also, here's a quick Python script to check whether files are missing the license:



import os

files = [os.path.join(dp, f) for dp, dn, fn in 
         os.walk(os.path.expanduser("FirefoxSearch")) for f in fn]
for fname in files:
    if '.git' in fname: continue
    if '.idea' in fname: continue
    if 'geckoView' in fname: continue
    with open(fname) as f:
        if 'MPL' not in f.read():
            print fname
(Assignee)

Updated

3 years ago
Attachment #8447420 - Flags: review?(nalexander)
(Assignee)

Comment 3

3 years ago
Created attachment 8447435 [details] [diff] [review]
bug-1031534-fix.patch

Fixed commenting style
Attachment #8447420 - Attachment is obsolete: true
Attachment #8447435 - Flags: review?(nalexander)
(Assignee)

Updated

3 years ago
Attachment #8447435 - Flags: review?(nalexander)
(Assignee)

Comment 4

3 years ago
Created attachment 8447442 [details] [diff] [review]
bug-1031534-fix.patch
Attachment #8447435 - Attachment is obsolete: true
Attachment #8447442 - Flags: review?(nalexander)
Attachment #8447442 - Flags: review?(nalexander) → review+
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
This patch never landed, did it? Eric, typical practice is to resolve bugs once the patch lands on mozilla-central.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 6

3 years ago
Hi Ryan, on this project, for the moment, we're committing changes through a GitHub repo [1], and then pushing to M-C as a separate workflow [2]. So this particular patch was landed through that pull request.

1. https://github.com/ericedens/FirefoxSearch/pull/12/files
2. https://bugzilla.mozilla.org/show_bug.cgi?id=1021864
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
Fair enough. In the future, it's always good form to post changeset links to wherever you committed the patch to, though.
You need to log in before you can comment on or make changes to this bug.