1031695 - [Contacts] Detail view not working in contacts when running in Firefox desktop

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Francisco Jordano [:arcturus] [:francisco]]

Right now we have the following js error, probably cause of the lack of support:

NS_ERROR_FILE_NOT_FOUND:  details.js:685
TypeError: telephony.conferenceGroup is undefined telephony_helper.js:245

We should avoid to throw that error and continue working on desktop

Comment 1

[Achal]

Do we need to suppress the error by checking for undefined and return null or try to fix the issue?

Comment 2

[Vikas S Yaligar]

I am not able to reproduce this bug.

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Hi Vikas,

I've tried this again and you are right, is not reproducible anymore, will close it as worksforme.

Thanks folks for helping out!

Comment 4

[Achal]

I am still getting this TypeError: telephony.conferenceGroup is undefined telephony_helper.js:245 error.

To be specific I got this in my console.
JavaScript error: app://communications.gaiamobile.org/dialer/js/telephony_helper.js, line 266: telephony.conferenceGroup is undefined

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Achal from comment #4)
> I am still getting this TypeError: telephony.conferenceGroup is undefined
> telephony_helper.js:245 error.
> 
> To be specific I got this in my console.
> JavaScript error:
> app://communications.gaiamobile.org/dialer/js/telephony_helper.js, line 266:
> telephony.conferenceGroup is undefined

Hi!

thanks for the info, I'll open a new bug to track that specific problem.

Would you like to help to fix it?

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Sorry,

actually is the same bug, so will reopen this one.

Thanks!

Comment 7

[Achal]

Hi Francisco,

I would like to work on this bug. I may need some help, so can you mentor me?

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Sure Achal!

It will be a pleasure, I would start on the telephony_helper.js file, doing a check of conferenceGroup in the telephony object.

Comment 9

[Achal]

Attachment: PR to add condition to check telephony.conferenceGroup is undefined

Hi Francisco, I have added a PR. Please review it.

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8482370 [details] [review]
PR to add condition to check telephony.conferenceGroup is undefined

Redirecting the review to a dialer peer, since this helper was created by then.

Comment 11

[Anthony Ricaud (:rik)]

Thanks!

Can you just modify your commit message to "Bug 1031695 - [Contacts] Detail view not working in contacts when running in Firefox desktop." ? Thanks!

Comment 12

[Achal]

Hi Anthony, thanks for reviewing it. I have modified the commit message.

Comment 13

[Anthony Ricaud (:rik)]

And this is merged: https://github.com/mozilla-b2g/gaia/commit/e8397125486cf44c84c0cb9ff8ae26195c741343.

Comment 14

[Achal]

Thanks Anthony & Francisco for helping me fixing and merging this bug patch. BTW this is my first bug patch that went all the way to the repo. Thanks for your support.

Comment 15

[Anthony Ricaud (:rik)]

Yeaaaah http://ricaud.me/images/success-2.gif

Comment 16

[Achal]

Haha, I loved his expression, HELL YEAAHH...