Converting email to event shouldn't fail when Thunderbird Conversations is installed

RESOLVED FIXED in 3.3

Status

Calendar
Lightning Only
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: merike, Assigned: merike)

Tracking

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8447739 [details] [diff] [review]
extract_conversations

This makes conversion work with Conversations enabled and in the case of one selected message also makes use of selection content. And since conversion fails similarly with multiple selected massages at the moment the extra null-check should fix that too, although only contents of the first selected message get used. But that should be better than complete failure.
Attachment #8447739 - Flags: review?(philipp)
Comment on attachment 8447739 [details] [diff] [review]
extract_conversations

Review of attachment 8447739 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp. This seems like a simple enough fix, maybe we can take it for 3.3 ?

::: calendar/base/modules/calExtract.jsm
@@ +342,4 @@
>          this.extractDuration("duration.hours", 60);
>          this.extractDuration("duration.days", 60 * 24);
>  
> +        if (sel !== undefined && sel !== null) {

Might just want to relax the check to if (sel) ? Don't do that if sel can be 0 and thats valid though.
Attachment #8447739 - Flags: review?(philipp)
Attachment #8447739 - Flags: review+
Attachment #8447739 - Flags: approval-calendar-beta+
Attachment #8447739 - Flags: approval-calendar-aurora+
Target Milestone: --- → 3.3
I've pushed this to beta so I can do a new beta build with it. 

https://hg.mozilla.org/releases/comm-beta/rev/4ce15fe64452

Leaving open for aurora and central.
Keywords: checkin-needed
https://hg.mozilla.org/releases/comm-aurora/rev/9334a332531a
https://hg.mozilla.org/comm-central/rev/1e169f987768
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.