1031715 - Converting email to event shouldn't fail when Thunderbird Conversations is installed

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Comment 1

[Merike Sell (:merike)]

Attachment: extract_conversations

This makes conversion work with Conversations enabled and in the case of one selected message also makes use of selection content. And since conversion fails similarly with multiple selected massages at the moment the extra null-check should fix that too, although only contents of the first selected message get used. But that should be better than complete failure.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8447739 [details] [diff] [review]
extract_conversations

Review of attachment 8447739 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp. This seems like a simple enough fix, maybe we can take it for 3.3 ?

::: calendar/base/modules/calExtract.jsm
@@ +342,4 @@
>          this.extractDuration("duration.hours", 60);
>          this.extractDuration("duration.days", 60 * 24);
>  
> +        if (sel !== undefined && sel !== null) {

Might just want to relax the check to if (sel) ? Don't do that if sel can be 0 and thats valid though.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I've pushed this to beta so I can do a new beta build with it. 

https://hg.mozilla.org/releases/comm-beta/rev/4ce15fe64452

Leaving open for aurora and central.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

https://hg.mozilla.org/releases/comm-aurora/rev/9334a332531a
https://hg.mozilla.org/comm-central/rev/1e169f987768