Closed
Bug 1031715
Opened 10 years ago
Closed 10 years ago
Converting email to event shouldn't fail when Thunderbird Conversations is installed
Categories
(Calendar :: Lightning Only, defect)
Calendar
Lightning Only
Tracking
(Not tracked)
RESOLVED
FIXED
3.3
People
(Reporter: merike, Assigned: merike)
References
Details
Attachments
(1 file)
1.53 KB,
patch
|
Fallen
:
review+
Fallen
:
approval-calendar-aurora+
Fallen
:
approval-calendar-beta+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
This makes conversion work with Conversations enabled and in the case of one selected message also makes use of selection content. And since conversion fails similarly with multiple selected massages at the moment the extra null-check should fix that too, although only contents of the first selected message get used. But that should be better than complete failure.
Attachment #8447739 -
Flags: review?(philipp)
Comment 2•10 years ago
|
||
Comment on attachment 8447739 [details] [diff] [review] extract_conversations Review of attachment 8447739 [details] [diff] [review]: ----------------------------------------------------------------- r=philipp. This seems like a simple enough fix, maybe we can take it for 3.3 ? ::: calendar/base/modules/calExtract.jsm @@ +342,4 @@ > this.extractDuration("duration.hours", 60); > this.extractDuration("duration.days", 60 * 24); > > + if (sel !== undefined && sel !== null) { Might just want to relax the check to if (sel) ? Don't do that if sel can be 0 and thats valid though.
Attachment #8447739 -
Flags: review?(philipp)
Attachment #8447739 -
Flags: review+
Attachment #8447739 -
Flags: approval-calendar-beta+
Attachment #8447739 -
Flags: approval-calendar-aurora+
Updated•10 years ago
|
Target Milestone: --- → 3.3
Comment 3•10 years ago
|
||
I've pushed this to beta so I can do a new beta build with it. https://hg.mozilla.org/releases/comm-beta/rev/4ce15fe64452 Leaving open for aurora and central.
Updated•10 years ago
|
Keywords: checkin-needed
Comment 4•10 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/9334a332531a https://hg.mozilla.org/comm-central/rev/1e169f987768
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Keywords: checkin-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•