103181 - Regression found in the disable code in AccountManager

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Rodney Velasco]

The bug exhibits itself when switching from one pane to another pane of the same
type, but a different server.  For example: switching from the server page for
server1, to the server page for nntp1.  So the xul page stays the same, but the
values change.  When this happens, the disabled attribute is not correctly
handled in all cases.

Comment 1

[Rodney Velasco]

Add these lines to your all.js file, start mail client and edit your mail/news
account settings. Switch panes between your mail server addressing category and
the news server addressing category.

lockPref("mail.identity.id3.drafts_folder_picker_mode", 0);
lockPref("mail.identity.id3.draft_folder", "mailbox://nobody@Local Folders/Drafts");
lockPref("mail.identity.id3.tmpl_folder_picker_mode", 1);
lockPref("mail.identity.id3.stationery_folder",
"mailbox://nobody@Local%20Folders/Templates");
lockPref("mail.identity.id3.overrideGlobal_Pref", true);


This is a regression of bug 70623 I believe.

Comment 2

[Ninoschka Baca]

Branch 2001-10-04-05: WinMe
Trunk 2001-10-04: Mac 9.1
How do I recreate this problem since I can't reproduce the problem with these
builds?

Comment 3

[Rodney Velasco]

This is actually dependent on you having multiple mail accounts if you are using
the example I described.  an id3 identity key needs to be created, you can
validate this by looking in your prefs.js, if you don't have it, create another
account.  Once that is done, toggle between the addressing categories for each
of the accounts created.you will notice that the attributes of the locked
identity will be seen on all the identities addressing prefs (Radio Boxes are
locked across all accounts).

Comment 4

[Jaime Rodriguez, Jr.]

what are the chances of this making the 094 branch?

Comment 5

[eddyk]

I believe I can have something available for review today to fix the
AccountMananger portion.  

There are still a couple of problems which are not directly related, but need to
be fixed in order for the copies and folders panel to work correctly.  I'll
create a new bug to track those issues.

Comment 6

[eddyk]

Attachment: propsed patch

Comment 7

[eddyk]

Description of problem and patch:
  the switching between the same panel types resulted in old values (disabled,
or checked) persisting to the newly selected panel.

In AccountManager.js I add the else statement to remove the disabled property,
whereas before, I was only setting it.  This will fix any problems with the
disabled attribute persisting across panels, if AccountManager code is used to
populate the xul elements.
In am-addressing.js and am-copies.js additional code was added to handle
switching between panels.  In particular, radiogroup handling needed
modification because it is not handled by AccountManager.
Finally, please see bug 82639 for resolution of the problem where clicking on a
radiogroup that looks disabled causes the group to enable itself.

Comment 8

[racham]

looks good. 
r=bhuvan.

Comment 9

[Jaime Rodriguez, Jr.]

when do we believe this could be ready to land on the 094 branch? should this
bug be nsbranch+, since it is a regression?

Comment 10

[(not reading, please use [e-mail] instead)]

seems ok to me.  sr=sspitzer

I'd suggest
         setEnabled(pageElements[i], !isLocked);

instead of 
         if (isLocked)
           setEnabled(pageElements[i],false);
         else
           setEnabled(pageElements[i],true);

Comment 11

[(not reading, please use [e-mail] instead)]

Comment on attachment 52286 [details] [diff] [review]
propsed patch

sr=sspitzer

Comment 12

[(not reading, please use [e-mail] instead)]

Comment on attachment 52286 [details] [diff] [review]
propsed patch

sr=sspitzer

Comment 13

[eddyk]

Attachment: patch with seth's comment incorporated.

Comment 14

[eddyk]

This should be ready to land today.  r + sr have been completed.  I've tested
it, and am waiting for qa to give a final ok before I check in.

Comment 15

[Jaime Rodriguez, Jr.]

pls check this into the branch - PDT+

Comment 16

[Rodney Velasco]

Tested patch on windows and linux, locking is working as expected. No
regressions found with account manager functionality.  Eddy, can you check this
in today?

Comment 17

[Hong Kwon]

marking nsenterprise-; will be reevaluated for nsenterprise in future release.

Comment 18

[Rodney Velasco]

Actually this should be resolved fixed...eddy checked into the branch and trunk.
yesterday. 

Comment 19

[Rodney Velasco]

verified on branch using:
Mac OSX, OS 9.2.1 20011009
Windows 2000,ME 20011010
Linux 2.2 20011010
needs to be verified in trunk.

Comment 20

[Scott MacGregor]

Unfortunately this patch caused some regressions in the account manager as now
the user name and server name fields are showing up as editable. Please see 104253