1031850 - Mac default theme uses wrong gray color compared to other OS X apps

Status: NEW

(Core :: Graphics: Color Management, defect)

Description

[TGOS]

Attachment: FxTitleBar.png

A picture is worth a thousand words. Have a look at the attached image and play the "odd one out" game. Firefox is the only app with that issue, even Thunderbird has the correct color.

Comment 1

[:Gijs (he/him)]

What version of OS X is this?

Comment 2

[TGOS]

I'm using 10.9.3 and the issue seems to be that Firefox ignores the monitor profile. All my monitors are profiled with an USB monitor calibration device; if I choose the generic sRGB profile in the system prefs instead, all 4 apps look the same.

Comment 3

[:Gijs (he/him)]

(In reply to TGOS from comment #2)
> I'm using 10.9.3 and the issue seems to be that Firefox ignores the monitor
> profile. All my monitors are profiled with an USB monitor calibration
> device; if I choose the generic sRGB profile in the system prefs instead,
> all 4 apps look the same.

Does this mean other things like web content are also not colored correctly?

Comment 4

[TGOS]

(In reply to :Gijs Kruitbosch from comment #3)
> Does this mean other things like web content are also not colored correctly?

Good question. Not sure how to test that correctly. If I load the same PNG (the one attached to this bug) once in Safari and Firefox and read the RGB values of one chosen pixel using "DigitalColor Meter" I do indeed get different values for this single pixel. So yes, seems to affect content as well. As far as I followed the UI development, everything of the Fx window is content now (it's all drawn manually by Fx, not by the UI system) unless you choose to display the window title bar again (and if I do, the title bar has the correct shade).

Comment 5

[:Gijs (he/him)]

(In reply to TGOS from comment #4)
> (In reply to :Gijs Kruitbosch from comment #3)
> > Does this mean other things like web content are also not colored correctly?
> 
> Good question. Not sure how to test that correctly. If I load the same PNG
> (the one attached to this bug) once in Safari and Firefox and read the RGB
> values of one chosen pixel using "DigitalColor Meter" I do indeed get
> different values for this single pixel. So yes, seems to affect content as
> well. As far as I followed the UI development, everything of the Fx window
> is content now (it's all drawn manually by Fx, not by the UI system) unless
> you choose to display the window title bar again (and if I do, the title bar
> has the correct shade).

I believe your analysis is correct, but I wanted to exclude the possibility that it was the Firefox theme's fault for somehow specifying the gradient in an incorrect way... this sounds like it's a core color calibration issue...

Comment 6

[TGOS]

Okay, I found something really neat:

1. Go to http://www.colorkeeper.com/?page_id=235

2. Download "BToATestProfile.zip" (at the very bottom)

3. Copy the file "BToATestProfile.icc" to "~/Library/ColorSync/Profiles"

4. Open "System Preferences" -> "Displays" -> "Color"

5. Choose "TRC-LetTestingProfile"

Your whole system will look like you were eating the wrong mushrooms... well, except Fx, which will look as always. Okay, now Fx hides the window bar and draws all content itself, so there is no problem with an incorrectly shaded window bar - however, basically that means Fx draws all the colors wrong now and that's why it looks different than the rest of my system, images in Fx don't look the same either.

Comment 7

[TGOS]

Two other things that might be interesting: Using the TRC-LetTestingProfile, I found out that color rendering of Firefox (the Fx UI itself, not the content of a displayed webpage) improves if gfx.color_management.mode is changed from 2 (default) to 1. This means color management is now applied to all graphics and not just "tagged" ones (whatever tagged means in that context). And when enabling gfx.color_management.enablev4 as well, most parts of the UI are drawn correctly with only a few exceptions. So it seems Fx has everything build in which it needs to correctly honor monitor color profile, it just is disabled by default and for some reason never applied to some images or draw operations.