Closed Bug 1031878 Opened 10 years ago Closed 10 years ago

JS_SetWatchPoint / JS_ClearWatchPoint / JS_ClearWatchPointsForObject can be removed

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla34

People

(Reporter: jimb, Assigned: evilpie)

References

Details

Attachments

(1 file)

v1
5.44 KB, patch
jimb
: review+
Details | Diff | Splinter Review 
JS_SetWatchPoint, JS_ClearWatchPoint, and JS_ClearWatchPointsForObject no longer have any callers, and can be removed.

The machinery that supports them needs to stick around, because it's still 
available via Object.prototype.watch.
Attached patch v1 — — Splinter Review 
We could probably simplify jswatchpoint.cpp a bit now, but let's first remove the API.
Assignee: nobody → evilpies
Status: NEW → ASSIGNED
Attachment #8461772 - Flags: review?(jimb)
Attachment #8461772 - Flags: review?(jimb) → review+
https://hg.mozilla.org/mozilla-central/rev/94e20e7d2782
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: