103188 - Should window.prompter be enumerable?

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Steven Toth]

From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)
BuildID:    2001100403

This bug appeared after the fix to bug 99663.  After the fix, I re-ran the 
original test case and it is still broken, but it looks like for different 
reasons.  when the for loop goes over the window.prompter variable, it fails to 
wrap the object.  It looks like I don't have permission to do this.  

Reproducible: Always
Steps to Reproduce:
To use the test html page.

1. click on WRITE WINDOW, this generates JS exceptions.



Actual Results:  The exceptions generated are...
***********************************
Error: [Exception... "'JavaScript component does not have a method 
named: "getHelperForLanguage"' when calling method: 
[nsIClassInfo::getHelperForLanguage]"  nsresult: "0x80570030 
(NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)"  location: "JS frame :: 
http://bugzilla.mozilla.org/attachment.cgi?id=49359&action=view :: 
rewriteCallback :: line 38"  data: no]
Source File: http://bugzilla.mozilla.org/attachment.cgi?id=49359&action=view
Line: 38
*********************************8
Error: [Exception... "'JavaScript component does not have a method 
named: "getInterfaces"' when calling method: [nsIClassInfo::getInterfaces]"  
nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)"  
location: "JS frame :: http://bugzilla.mozilla.org/attachment.cgi?
id=49359&action=view :: rewriteCallback :: line 38"  data: no]
Source File: http://bugzilla.mozilla.org/attachment.cgi?id=49359&action=view
Line: 38
************************
Error: uncaught exception: Permission denied to create wrapper for object 

Expected Results:  Generated a page that has all the properties of the window 
variable in it.

here is the JS function being called...
function rewriteCallback()
{
 //netscape.security.PrivilegeManager.enablePrivilege('AllPermissions');
 var printer = '';
 var win2  = window.open("about:blank");
 win2.document.open();
 for ( var xx in window )
 {
     printer += xx+'  =  ';
     try
     {
     if (typeof window[xx] =='function' )
     printer+='function\n';
     else
     printer+=window[xx]+'\n';
     } catch (e)
     {
     printer += e;
     }
     win2.document.writeln('<p>'+printer);
     printer='';
 }
  win2.document.close();
}

Comment 1

[Steven Toth]

Attachment: Test page demostrating bug

Comment 2

[Jesse Ruderman]

-> js security (or should prompter not be showing up on an enumeration of the 
window object?)

Comment 3

[Brendan Eich [:brendan]]

What is prompter?  At first glance, it should not be enumerable.

/be

Comment 4

[Fabian Guisset]

nsGlobalWindow#885
NS_IMETHODIMP GlobalWindowImpl::GetPrompter(nsIPrompt** aPrompt)
{
  nsCOMPtr<nsIPrompt> prompter(do_GetInterface(mDocShell));
}
re-cc'ing jst

Comment 5

[Mitchell Stoltz (not reading bugmail)]

Well enabling 'AllPermissions' won't work in this situation. Alpermission only
applies to Java applets, actually, it gives no DOM permissions. Sorry, I know
that's misleading. The permission that gives you all permissions in Javascript
is 'UniversalXPConnect'. I should make these two equivalent; I'll file a bug on
that. 

Note that your script needs to be signed or else run locally in order for
enabling permissions to work.

As for 'prompter,' is that part of the public API? Should it be? jst?

Comment 6

[Mitchell Stoltz (not reading bugmail)]

Changing summary and reassigning to jst.

Comment 7

[Johnny Stenback (:jst)]

window.prompter was added by dougt when fixing bug 47889, but I don't see
window.prompter being used anywhere in our JS (not in mozilla nor commercial),
so we could mark it [noscript] and this bug would be fixed. Comments?

Comment 8

[Johnny Stenback (:jst)]

Doug, any objections to making nsIDOMWindow::prompter [noscript]?

Comment 9

[Doug Turner (:dougt)]

fine with me.  probably should have been noscript from the start.

Comment 10

[Johnny Stenback (:jst)]

Attachment: Proposed fix.

Comment 11

[John Keiser (jkeiser)]

Comment on attachment 53694 [details] [diff] [review]
Proposed fix.

r=jkeiser

Comment 12

[Johnny Stenback (:jst)]

Fixed.

Comment 13

[bsharma]

Updated QA contact