Closed
Bug 1031880
Opened 10 years ago
Closed 10 years ago
JS_SetSingleStepMode should be removed
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: jimb, Assigned: evilpie)
References
Details
Attachments
(1 file)
|
6.45 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
JS_SetSingleStepMode no longer has any callers, so it and its supporting machinery can be removed. In particular, DebugScript::stepMode no longer needs its special top-bit-set behavior, so that and everything that copes with it can go.
|
Assignee | |
Comment 1•10 years ago
|
||
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8481572 [details] [diff] [review] remove-single-step Review of attachment 8481572 [details] [diff] [review]: ----------------------------------------------------------------- Great!
Attachment #8481572 -
Flags: review?(jorendorff) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=20ab3377da52 https://hg.mozilla.org/integration/mozilla-inbound/rev/674b44ed6490
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/674b44ed6490
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•