103190 - Windows Classic: paragraph drop-down does not show what style is chosen when open00

Status: VERIFIED WONTFIX

(SeaMonkey :: Themes, defect)

Description

[TucsonTester2]

Build ID: 20011002

The paragraph style drop-down on the toolbar in composer does not show what
paragraph style is chosen when the list is opened.  It should somehow represent
what is chosen by a bullet or a check mark.

Reproducible: Always

Steps to Reproduce:
1.Open composer
2.Click on the paragraph style drop-down on the toolbar and choose Heading 1
3.Click on the paragraph style drop-down to expand it

Actual Results:
The menu does not indicate what style is currently selected.  It does highlight
what is chosen, but if you run across the different styles that will go away.

Expected Results:
I would expect that the currently chosen paragraph style would be indicated with
a bullet or checkmark in the menu when it is expanded.

Comment 1

[michael wendell]

Confirmed on build 2001110703.

Comment 2

[Joe Hewitt (gone)]

-> [e-mail]

Comment 3

[shliang]

Attachment: selected menuitem is checked

changing all menulists so that selected menuitem is checked

Comment 4

[Joe Hewitt (gone)]

Comment on attachment 58067 [details] [diff] [review]
selected menuitem is checked

sr=hewitt

Comment 5

[andreww]

Comment on attachment 58067 [details] [diff] [review]
selected menuitem is checked

r=andreww

Comment 6

[Blake Ross]

Why was this done?  This is not how Windows dropdowns behave, and Classic should
be emulating OS widgets.  It doesn't even seem to be a useful enhancement, as
the previously selected item is visible in the widget itself (above the
dropdown).  I think we should back this out pending further discussion.

Comment 7

[Lori Kaplan]

Upon consultation of the Windows guidelines, it seems that the menus in question
should follow the menu guidelines and include checkmarks next to the current
selection. See pp. 153 where it discusses that "the interface for drop-down list
boxes is similar to that for menus." While no specifics are given, it infers
that the menu guidelines apply thus there should be a mark in a single selection
list. See pg 144 and 136. Additionally with the drop-down lists in the prefs
d.b. having so many items in them, an indication of the current selection is a
helpful navigation guide since the menu title is so far from the user's current
focus. There is no relative gauge in the font size drop downs. The check marks
help users to compare items within the list without the cognitive overhead of
jumping up to look at the title and back down to the list contents repeatedly. 

Comment 8

[shliang]

this has been backed out

Comment 9

[shliang]

checking in again - see lori's comment

Comment 10

[Blake Ross]

The guidelines do not specifically state that, and indeed it is not how the
standard Windows menulist behaves (i.e., if we were using native controls, this
behavior would not exist).  The point of Classic is to mimic the OS exactly, not
to extend or change the behavior of standard controls, even if we feel they
might be useful enhancements.

Comment 11

[Lori Kaplan]

You are correct. As I said, the guidelines infer it. Guidelines do just that.
They aren't rules and they can't cover all cases. Just because someone
interprets the guidelines in a particular way doesn't mean they're right for
every situation. In this case, I believe optimizing the feedback for the target
user is the best option. 

Comment 12

[michael wendell]

Verified on build 2001121203.

Comment 13

[Blake Ross]

I don't think that inference is clear at all; and it should be evident from the 
fact that native Windows dropdowns do not exhibit this behavior that this is 
not what the spec intends.  As Joe says in bug 112437,

"We have no intention of "improving" the native widgets, we are trying to 
emulate them as best as possible.  This is a definite WONTFIX."

Indeed, that is the very purpose of Classic, and any attempt to try to improve 
upon the fundamental OS widgets should not be taken lightly.  I still think 
this warrants more discussion if we're going to give the user a different 
experience than that which he has in every other program on his computer, 
especially in the Classic theme, which is intended to be an exact emulation of 
the OS.  I do not think we should open up the can of worms of extending OS 
behavior in Classic, so reopening for more feedback from interested parties.

Comment 14

[Blake Ross]

In general, I agree that the checkmark may be a useful enhancement in such long 
menulists as the Font dropdowns, provided the user understands its purpose.  Of 
course, such long menulists are probably scrollable, which means the checkmark 
won't always be visible (whereas the top part of the widget will).  I'm also 
uncertain of the validity of the scenario you describe without the checkbox, 
that users would constantly have to be looking back up to see the currently 
selected item.  Can't users remember something in short term memory for a few 
seconds?  The only case I can see this possibly being useful in is when you 
have multiple variations of the same font, e.g. Rockwell, Rockwell Bold, 
Rockwell Light, etc. that are in close proximity.  However, few menulists in 
the product are as long as the one in fonts.  (Also, I can only assume that the 
font prefs are geared toward advanced users, as it's not as if the average user 
knows what the fonts on his computer look like without some sort of preview.)

Honestly, as I said, I vote we leave Classic to what it was meant to be -- an 
OS emulation -- and not get into the business of trying to improve upon core 
Windows widgets.

Comment 15

[shliang]

marking wontfix

Comment 16

[michael wendell]

Verified.