1031915 - fails to process ranges against old nightlies

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[(mostly gone) XtC4UaLL [:xtc4uall]]

$ mozregression --good=2011-12-09 --bad=2012-02-20 --args="https://bugzilla.mozilla.org/attachment.cgi?id=8441518" --bits=32
Running nightly for 2012-01-14
Downloading build from: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2012/01/2012-01-14-03-10-54-mozilla-central/firefox-12.0a1.en-US.win32.zip.asc
===== Downloaded 8668% =====
Installing nightly
Traceback (most recent call last):
  File "c:\mozilla-build\python\Scripts\mozregression-script.py", line 8, in <module>
    load_entry_point('mozregression==0.18', 'console_scripts', 'mozregression')()
  File "build\bdist.win32\egg\mozregression\regression.py", line 316, in cli
  File "build\bdist.win32\egg\mozregression\regression.py", line 180, in bisect_nightlies
  File "build\bdist.win32\egg\mozregression\runnightly.py", line 317, in start
  File "build\bdist.win32\egg\mozregression\runnightly.py", line 314, in install
  File "build\bdist.win32\egg\mozregression\runnightly.py", line 125, in install
  File "c:\mozilla-build\python\lib\site-packages\mozinstall-1.10-py2.7.egg\mozinstall\mozinstall.py", line 110, in install
    raise InvalidSource(src + ' is not valid installer file.')
mozinstall.mozinstall.InvalidSource: C:\Users\Marc\firefox-12.0a1.en-US.win32.zip.asc is not valid installer file.

Why is it trying to process asc files?
Above does not happen in 2014 nightlies.

Comment 1

[Sam Garrett]

Attachment: Fixes bug by adding $ mark for end of regex matching

https://github.com/mozilla/mozregression/pull/108

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8451308 [details] [review]
Fixes bug by adding $ mark for end of regex matching

Looks good, we should be stricter on other platforms too though. Applied the same logic to the other regular expression return values from that function. 

https://github.com/mozilla/mozregression/commit/eccbfb90991be1e07d09e0b0722e54f3a2279a6f