1031945 - The "dom.disable_window_showModalDialog" preference should hide window.showModalDialog

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masatoshi Kimura [:emk]]

See bug 981796 comment #4.
This bug should be trivial because bug 789261 is alreay fixed.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Don't expose showModalDialog on Window if it's preffed off

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8460749 [details] [diff] [review]
Don't expose showModalDialog on Window if it's preffed off


>-  if (Preferences::GetBool("dom.disable_window_showModalDialog", false)) {
>+  if (Preferences::GetBool(sShowModalDialogPref, false)) {
Why not use !IsShowModalDialogEnabled(nullptr, nullptr) here

Comment 3

[Boris Zbarsky [:bzbarsky]]

> Why not use !IsShowModalDialogEnabled(nullptr, nullptr) here

Good idea,  Done, but I made the args default to nullptr, so:

  if (!IsShowModalDialogEnabled()) {

Comment 4

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f1224e8676b1

Comment 5

[Boris Zbarsky [:bzbarsky]]

And backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/c1354624b6fe

Android and b2g set this pref.  This causes two test failures:

Two issues:

1) js/src/tests/js1_5/Regress/regress-328897.js is a broken-ass test that uses showModalDialog to trigger an exception, and now it's getting the wrong exception.  It's also almost certainly no longer testing what it meant to be testing; I'll look into just removing it.

2) dom/imptests/html/html/browsers/the-window-object/test_window-properties.html expects this method to be there.  Can we just fix that?  ;)

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Update test

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://github.com/w3c/web-platform-tests/pull/1122

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://tbpl.mozilla.org/?tree=Try&rev=4ddf64223647

Comment 9

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3631c6245ed4

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3631c6245ed4