1031987 - Can't debug text/jsx react files

Status: RESOLVED WORKSFORME

(DevTools :: Debugger, defect)

Description

[Mike Shaver (:shaver emeritus)]

The debugger refuses to load a file with react's JSX markup in it, so you can't see syntax error locations or set breakpoints or such. Chrome's manages to, which is very welcome. (I think it doesn't parse the file other than to do syntax highlighting, which is indeed a bit off, but not that big a deal as a developer debugging stuff.)

Comment 1

[Jeff Griffiths (:canuckistani) (:⚡︎)]

cc'ing James because he's the resident react fanboy.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Is there any related error in the browser console (Cmd+Shift+J)?

Comment 3

[James Long (:jlongster)]

Strange, this is definitely something we need to fix. Thanks for CC'ing me on it!

Comment 4

[Mike Shaver (:shaver emeritus)]

Nick: I don't recall there being one, no, but I suspect that James can reproduce it thoroughly.

Comment 5

[Jeff Griffiths (:canuckistani) (:⚡︎)]

James, is this fixed? We have bug 1164853 specifically about syntax highlighting for jsx, and it seems to indicate that the situation generally has improved thanks probably to you and Eddy.

Comment 6

[James Long (:jlongster)]

Oops, I forgot about this bug. I guess it is fixed :) I can double-check tomorrow. I didn't fix anything about it specifically, but the way sources are loaded has changed a good bit (in particular with sourcemaps) so it probably got fixed along the way.

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Assuming this is fixed based on comments, reopen if not.