Remove MOZ_SERVICES_FXACCOUNTS flags as it is no longer necessary - Perma-orange on TB trunk: TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | Source file test_hawkrequest.js contains an error

RESOLVED FIXED in Firefox 33

Status

RESOLVED FIXED
4 years ago
6 months ago

People

(Reporter: jcranmer, Assigned: standard8)

Tracking

({intermittent-failure})

unspecified
mozilla33
intermittent-failure
Dependency tree / graph

Firefox Tracking Flags

(firefox31 unaffected, firefox32 unaffected, firefox33 fixed, firefox-esr24 unaffected)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
After a painful session with gdb, the file that Components.utils.import failed on is
reource://gre/modules/Credentials.jsm, defined in services/fxaccounts/Credentials.jsm and only included if MOZ_SERVICES_FXACCOUNTS is defined.

Not sure what the best fix is here.
(Reporter)

Updated

4 years ago
Flags: needinfo?(standard8)
Jed, Chris, what would you say to moving Credentials.jsm from services/fxaccounts to services/common?

AFAICT Credentials.jsm isn't too fxaccounts specific (everyone currently seems to be using the same PROTOCOL_VERSION)
Flags: needinfo?(standard8)
Flags: needinfo?(jparsons)
Flags: needinfo?(ckarlof)
That build flag was added in Bug 976002 to prevent fxa code from shipping in FxOS 1.4.

But it seems like maybe we can remove the build flag now?

:ferjm, what do you think?
Flags: needinfo?(jparsons) → needinfo?(ferjmoreno)
Credentials.jsm is somewhat FxA specific (it helps derive FxA credentials). If removing that build flag solves the issue and is safe for B2G, I'd prefer that.
Flags: needinfo?(ckarlof)
I am probably not the best person to make the call about FxA being fully ready to remove this build flag.
Flags: needinfo?(spenrose)
Flags: needinfo?(gps)
Flags: needinfo?(ferjmoreno)

Comment 5

4 years ago
We should remove the flag. FxA has landed for FxOS 2.0.
Flags: needinfo?(spenrose)
Flags: needinfo?(gps)
I can do the removal.
Assignee: nobody → standard8
Component: Testing Infrastructure → Build Config
Keywords: intermittent-failure
Product: Thunderbird → Core
Summary: Perma-orange on TB trunk: TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | Source file /builds/slave/talos-slave/test/build/xpcshell/tests/services/common/tests/unit/test_hawkrequest.js contains an error → Remove MOZ_SERVICES_FXACCOUNTS flags as it is no longer necessary - Perma-orange on TB trunk: TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | Source file test_hawkrequest.js contains an error
Created attachment 8450144 [details] [diff] [review]
Removes MOZ_SERVICES_FXACCOUNTS flag

This removes the build flag as suggested.
Attachment #8450144 - Flags: review?(mh+mozilla)
Comment on attachment 8450144 [details] [diff] [review]
Removes MOZ_SERVICES_FXACCOUNTS flag

Review of attachment 8450144 [details] [diff] [review]:
-----------------------------------------------------------------

r+ as long as services.sync.fxaccounts.enabled can be used to disable the feature.
Attachment #8450144 - Flags: review?(mh+mozilla) → review+
(In reply to Mike Hommey [:glandium] from comment #8)
> r+ as long as services.sync.fxaccounts.enabled can be used to disable the
> feature.

Can anyone confirm this?
Flags: needinfo?(jed+bmo)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(In reply to Mark Banner (:standard8) from comment #9)
> (In reply to Mike Hommey [:glandium] from comment #8)
> > r+ as long as services.sync.fxaccounts.enabled can be used to disable the
> > feature.
> 
> Can anyone confirm this?

It's actually identity.fxaccounts.enabled that disables Firefox Accounts, but yes, the service can be disabled.

And as Sam confirms in Comment 5, we can remove this flag now.
Flags: needinfo?(jed+bmo)
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c4f860f8697
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla33
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
https://hg.mozilla.org/mozilla-central/rev/1c4f860f8697
https://hg.mozilla.org/mozilla-central/rev/721560134f54
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Comment hidden (Treeherder Robot)
status-firefox31: --- → unaffected
status-firefox32: --- → unaffected
status-firefox33: --- → fixed
status-firefox-esr24: --- → unaffected

Updated

6 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.