Closed
Bug 1032017
Opened 10 years ago
Closed 10 years ago
Remove MOZ_SERVICES_FXACCOUNTS flags as it is no longer necessary - Perma-orange on TB trunk: TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | Source file test_hawkrequest.js contains an error
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox31 unaffected, firefox32 unaffected, firefox33 fixed, firefox-esr24 unaffected)
RESOLVED
FIXED
mozilla33
Tracking | Status | |
---|---|---|
firefox31 | --- | unaffected |
firefox32 | --- | unaffected |
firefox33 | --- | fixed |
firefox-esr24 | --- | unaffected |
People
(Reporter: jcranmer, Assigned: standard8)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
6.32 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
After a painful session with gdb, the file that Components.utils.import failed on is reource://gre/modules/Credentials.jsm, defined in services/fxaccounts/Credentials.jsm and only included if MOZ_SERVICES_FXACCOUNTS is defined. Not sure what the best fix is here.
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(standard8)
Assignee | ||
Comment 1•10 years ago
|
||
Jed, Chris, what would you say to moving Credentials.jsm from services/fxaccounts to services/common? AFAICT Credentials.jsm isn't too fxaccounts specific (everyone currently seems to be using the same PROTOCOL_VERSION)
Flags: needinfo?(standard8)
Flags: needinfo?(jparsons)
Flags: needinfo?(ckarlof)
Comment 2•10 years ago
|
||
That build flag was added in Bug 976002 to prevent fxa code from shipping in FxOS 1.4. But it seems like maybe we can remove the build flag now? :ferjm, what do you think?
Flags: needinfo?(jparsons) → needinfo?(ferjmoreno)
Comment 3•10 years ago
|
||
Credentials.jsm is somewhat FxA specific (it helps derive FxA credentials). If removing that build flag solves the issue and is safe for B2G, I'd prefer that.
Flags: needinfo?(ckarlof)
Comment 4•10 years ago
|
||
I am probably not the best person to make the call about FxA being fully ready to remove this build flag.
Flags: needinfo?(spenrose)
Flags: needinfo?(gps)
Flags: needinfo?(ferjmoreno)
Comment 5•10 years ago
|
||
We should remove the flag. FxA has landed for FxOS 2.0.
Flags: needinfo?(spenrose)
Flags: needinfo?(gps)
Assignee | ||
Updated•10 years ago
|
Component: Testing Infrastructure → Build Config
Keywords: intermittent-failure
Product: Thunderbird → Core
Summary: Perma-orange on TB trunk: TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | Source file /builds/slave/talos-slave/test/build/xpcshell/tests/services/common/tests/unit/test_hawkrequest.js contains an error → Remove MOZ_SERVICES_FXACCOUNTS flags as it is no longer necessary - Perma-orange on TB trunk: TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | Source file test_hawkrequest.js contains an error
Assignee | ||
Comment 7•10 years ago
|
||
This removes the build flag as suggested.
Attachment #8450144 -
Flags: review?(mh+mozilla)
Comment 8•10 years ago
|
||
Comment on attachment 8450144 [details] [diff] [review] Removes MOZ_SERVICES_FXACCOUNTS flag Review of attachment 8450144 [details] [diff] [review]: ----------------------------------------------------------------- r+ as long as services.sync.fxaccounts.enabled can be used to disable the feature.
Attachment #8450144 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 9•10 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #8) > r+ as long as services.sync.fxaccounts.enabled can be used to disable the > feature. Can anyone confirm this?
Flags: needinfo?(jed+bmo)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 23•10 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #9) > (In reply to Mike Hommey [:glandium] from comment #8) > > r+ as long as services.sync.fxaccounts.enabled can be used to disable the > > feature. > > Can anyone confirm this? It's actually identity.fxaccounts.enabled that disables Firefox Accounts, but yes, the service can be disabled. And as Sam confirms in Comment 5, we can remove this flag now.
Flags: needinfo?(jed+bmo)
Assignee | ||
Comment 24•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c4f860f8697
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla33
Assignee | ||
Comment 25•10 years ago
|
||
Also with follow-up bustage fix: https://hg.mozilla.org/integration/mozilla-inbound/rev/721560134f54
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 28•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1c4f860f8697 https://hg.mozilla.org/mozilla-central/rev/721560134f54
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment hidden (Legacy TBPL/Treeherder Robot) |
Updated•10 years ago
|
status-firefox31:
--- → unaffected
status-firefox32:
--- → unaffected
status-firefox33:
--- → fixed
status-firefox-esr24:
--- → unaffected
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•