Closed Bug 1032018 Opened 8 years ago Closed 8 years ago

Loop xpcshell tests will fail when mozilla-central 33 is merged to mozilla-aurora on July 21st

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla33

People

(Reporter: philor, Assigned: standard8)

Details

Attachments

(1 file)

The xpcshell oranges in https://tbpl.mozilla.org/?tree=Try&rev=7063f448a5cb and https://tbpl.mozilla.org/?tree=Try&rev=d1e456cbb93b - apparently test_loopservice_expiry.js and test_loopservice_get_loop_char_pref.js and test_loopservice_initialize.js and test_loopservice_locales.js depend on a pref that's defined nightly-only, and don't do a good job of coping with it not being defined.

You've got three weeks to avoid permaorange, starting tomorrow.
Strange, I'm sure I remember adding this at some stage, but it clearly isn't there...

Simple if addition for the loop core parts. Try server run (with loop disabled) is here:

https://tbpl.mozilla.org/?tree=Try&rev=2fb1ee45a0ad

We're probably going to be moving to a pref-based on/off system before the end of the cycle, but just in case, we'll get this bug out the way away - as by the time I'd looked at it, I had the patch virtually written anyway.
Attachment #8447937 - Flags: review?(mh+mozilla)
Assignee: nobody → standard8
Target Milestone: --- → 33 Sprint 2- 7/7
Component: General → Client
Attachment #8447937 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/3dc373826e2a
Target Milestone: 33 Sprint 2- 7/7 → mozilla33
Untracking for QA.
Whiteboard: [qa-]
Flags: qe-verify-
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.