1032018 - Loop xpcshell tests will fail when mozilla-central 33 is merged to mozilla-aurora on July 21st

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Phil Ringnalda (:philor)]

The xpcshell oranges in https://tbpl.mozilla.org/?tree=Try&rev=7063f448a5cb and https://tbpl.mozilla.org/?tree=Try&rev=d1e456cbb93b - apparently test_loopservice_expiry.js and test_loopservice_get_loop_char_pref.js and test_loopservice_initialize.js and test_loopservice_locales.js depend on a pref that's defined nightly-only, and don't do a good job of coping with it not being defined.

You've got three weeks to avoid permaorange, starting tomorrow.

Comment 1

[Mark Banner (:standard8)]

Attachment: Don't build Loop core when building of Loop is disabled.

Strange, I'm sure I remember adding this at some stage, but it clearly isn't there...

Simple if addition for the loop core parts. Try server run (with loop disabled) is here:

https://tbpl.mozilla.org/?tree=Try&rev=2fb1ee45a0ad

We're probably going to be moving to a pref-based on/off system before the end of the cycle, but just in case, we'll get this bug out the way away - as by the time I'd looked at it, I had the patch virtually written anyway.

Comment 2

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3dc373826e2a

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3dc373826e2a

Comment 4

[u279076]

Untracking for QA.