Fix jshint error for build/pre-app.js

RESOLVED FIXED

Status

Firefox OS
Gaia::Build
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: yurenju, Assigned: xfq, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor-lang=zh])

Attachments

(1 attachment, 1 obsolete attachment)

46 bytes, text/x-github-pull-request
Details | Review | Splinter Review
+++ This bug was initially created as a clone of Bug #1032022 +++
Whiteboard: [good first bug][mentor-lang=zh]

Comment 1

4 years ago
Some guidance on how to approach this bug is available here:

https://bugzilla.mozilla.org/show_bug.cgi?id=1032045#c2
(Assignee)

Comment 2

4 years ago
Created attachment 8464418 [details] [review]
PR on GitHub
Attachment #8464418 - Flags: review?(yurenju.mozilla)
Assignee: nobody → xfq.free
Comment on attachment 8464418 [details] [review]
PR on GitHub

pull request looks good but we have conflict here, please rebase and push again then set needinfo? flag to me for merging this change, r=yurenju
Attachment #8464418 - Flags: review?(yurenju.mozilla) → review+
(Assignee)

Comment 4

3 years ago
Created attachment 8481285 [details] [review]
PRv2 on GitHub

Here's the new pull request.
Attachment #8464418 - Attachment is obsolete: true
merged.

https://github.com/mozilla-b2g/gaia/commit/71db2bd4ce18d47c0ddf0292cf61d2ed95351bc9
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.