1032030 - Fix jshint error for build/test/integration/build.test.js

Status: RESOLVED DUPLICATE of bug 1024386

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

+++ This bug was initially created as a clone of Bug #1032028 +++

Comment 1

[Mike Hoye [:mhoye]]

Some guidance on how to approach this bug is available here:

https://bugzilla.mozilla.org/show_bug.cgi?id=1032045#c2

Comment 2

[Sudheesh Singanamalla (:ShellHacker)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/22728

Comment 3

[Sudheesh Singanamalla (:ShellHacker)]

Having a small trouble here. Since there's a merge conflict, i've fetched from upstream, cleared the merge conflict but when I look at squashing I have no idea where to rebase this to.

commit 3e1fe4460e055052608992d82a7d99a0f724ab91
Merge: b171e6e e78e621
Author: sudheesh001 <[e-mail]>
Date:   Tue Aug 12 08:54:44 2014 +0530

    Fixes merge conflict

commit e78e62125eb43c3a28cdc047987ba54430694a2f
Author: Kevin Grandon <[e-mail]>
Date:   Mon Aug 11 20:04:02 2014 -0700

    Revert "Bug 1042105 - [User Story] Icon prioritization in the status bar"
    
    This reverts commit 7e4678128cdd6d296b67679fbe827845d19e7ec7.

commit a552eb785e92ea46741d2b843a37a54b04318508
Merge: 0a32abe 97a6099
Author: Yuren Ju <[e-mail]>
Date:   Tue Aug 12 10:38:33 2014 +0800

    Merge pull request #22444 from sudheesh001/Patch_1032036
    
    Fixes bug 1032036, build/test/integration/multilocale.test.js r=yurenju

There's an intermediate commit (b) between (a) and (c) where (a) and (c) have to be merged. Any help here ?

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8470769 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22728

I left some comments on github, please check it.

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

remove -W101 and try to solve all issues for long line. please thinking readability when you found an issue is not easy to fix

If break long line won't enhance readability, you don't need to do anything, otherwise please fix it. after go through all issue then you can add -W101 back for skipping corner cases.

Comment 6

[Sudheesh Singanamalla (:ShellHacker)]

Yuren I checked them and fixed them. Pushed back onto PR with a rebased and squashed commit.

Comment 7

[Sudheesh Singanamalla (:ShellHacker)]

Fixes line length issues also. These lines can't be corrected for easy readability

build/test/integration/build.test.js: line 300, col 85, Line is too long.
build/test/integration/build.test.js: line 307, col 89, Line is too long.
build/test/integration/build.test.js: line 312, col 85, Line is too long.
build/test/integration/build.test.js: line 317, col 106, Line is too long.

So preferred to fix the rest and leave these as it is and add -W101

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Sudheesh, still have two whitespace in trail of lines:

build/test/integration/build.test.js: line 401, col 61, Trailing whitespace.
build/test/integration/build.test.js: line 734, col 55, Trailing whitespace.

please use |jshint FILE_PATH| to check it.

Comment 9

[Sudheesh Singanamalla (:ShellHacker)]

I've fixed that but unable to pull changes and push a squashed commit to remove the merge conflict. Do I redo this into a new commit ?

Comment 10

[Sudheesh Singanamalla (:ShellHacker)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/23133

Sorry for the delay, Managed to push this as my 100th day commit on GitHub !

Thank you Mozilla :D

Comment 11

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8476502 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/23133

congrat!

but your patch have some error for build integration test, please use |make build-test-integration| to run the test, let's try to land it today :D

Comment 12

[Sudheesh Singanamalla (:ShellHacker)]

Yuren,

Here's a log of what I am facing

Sudheeshs-MacBook-Pro:GaiaCodebase sudheeshsinganamalla$ export https_proxy=172.30.0.22:3128
Sudheeshs-MacBook-Pro:GaiaCodebase sudheeshsinganamalla$ export http_proxy=172.30.0.22:3128
Sudheeshs-MacBook-Pro:GaiaCodebase sudheeshsinganamalla$ make build-test-integration
# Running make without using a dependency ensures that we can run
# "make node_modules" with a custom NODE_MODULES_GIT_URL variable, and then
# run another target without specifying the variable
/Applications/Xcode.app/Contents/Developer/usr/bin/make modules.tar
/usr/bin/curl -OL https://github.com/mozilla-b2g/gaia-node-modules/tarball/f6f8dc0f364cdf7b2a0f5c988962776250525339 &&\
	mv f6f8dc0f364cdf7b2a0f5c988962776250525339 "modules.tar"
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   178    0   178    0     0    139      0 --:--:--  0:00:01 --:--:--   140
100 17.0M  100 17.0M    0     0  1171k      0  0:00:14  0:00:14 --:--:-- 1867k
tar --strip-components 1 -x -m -f modules.tar "mozilla-b2g-gaia-node-modules-*/node_modules"
node_modules/.bin/_mocha: Can't create 'node_modules/.bin/_mocha'
node_modules/.bin/grunt-jsdoc: Can't create 'node_modules/.bin/grunt-jsdoc'
node_modules/.bin/js-test-agent: Can't create 'node_modules/.bin/js-test-agent'
node_modules/.bin/jshint: Can't unlink already-existing object
node_modules/.bin/marionette-mocha: Can't create 'node_modules/.bin/marionette-mocha'
node_modules/.bin/mocha: Can't create 'node_modules/.bin/mocha'
node_modules/.bin/mocha-parallel: Can't create 'node_modules/.bin/mocha-parallel'
node_modules/.bin/mozilla-download: Can't create 'node_modules/.bin/mozilla-download'
node_modules/.bin/rimraf: Can't create 'node_modules/.bin/rimraf'
node_modules/.bin/static: Can't create 'node_modules/.bin/static'
node_modules/.bin/travisaction: Can't create 'node_modules/.bin/travisaction'
node_modules/jshint/node_modules/.bin/shjs: Can't unlink already-existing object
node_modules/jshint/node_modules/.bin/strip-json-comments: Can't unlink already-existing object
tar: Error exit delayed from previous errors.
make: *** [node_modules] Error 1
Sudheeshs-MacBook-Pro:GaiaCodebase sudheeshsinganamalla$ sudo make build-test-integration
Password:
/bin/bash: ./node_modules/.bin/mocha: No such file or directory
make: *** [build-test-integration] Error 127
Sudheeshs-MacBook-Pro:GaiaCodebase sudheeshsinganamalla$ make build-test-integration
/bin/bash: ./node_modules/.bin/mocha: No such file or directory
make: *** [build-test-integration] Error 127
Sudheeshs-MacBook-Pro:GaiaCodebase sudheeshsinganamalla$

Comment 13

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Sudheesh, since you have used |sudo| for make, your gaia tree have two kind of files with different permissions, so you can't remove files without |sudo|.

I suggest you clone a new gaia repository again and never use |sudo| then you will have it with normal user permission.

Comment 14

[Sudheesh Singanamalla (:ShellHacker)]

I am facing the following error. Where exactly is the reference for matches ? is it in ./utils

 25 passing (14m)
  1 failing

  1) Integration tests make APP=system, checking all of the files are available:
     Uncaught ReferenceError: matches is not defined
      at extractSharedFile 

(/Users/sudheeshsinganamalla/Documents/Gaia2/build/test/integration/build.test.js:48:22)
      at verifyIncludedFilesFromHtml (/Users/sudheeshsinganamalla/Documents/Gaia2/build/test/integration/build.test.js:40:21)
      at /Users/sudheeshsinganamalla/Documents/Gaia2/build/test/integration/build.test.js:115:9
      at ChildProcess.exithandler (child_process.js:635:7)
      at ChildProcess.EventEmitter.emit (events.js:98:17)
      at maybeClose (child_process.js:743:16)
      at Socket.<anonymous> (child_process.js:956:11)
      at Socket.EventEmitter.emit (events.js:95:17)
      at Pipe.close (net.js:465:12)

Comment 15

[[:fabrice] Fabrice Desré]

I don't know, sorry.

Comment 16

[Mike Hoye [:mhoye]]

Hmm. Yuren, can you speak to Sudheesh's question?

Comment 17

[Ricky Chien [:rickychien] (inactive)]

Hi Sudheesh,

you should print console.log(matches) to find out what's going on. And remember to |git rebase master| to update latest master because we have some update recently. :)

Comment 18

[Ricky Chien [:rickychien] (inactive)]

Refer to bug 1024386#c2. We'll solve the rest of jshint errors in bug 1024386.