1032069 - [Bluetooth] Refactor BT app to make it embed-able from Settings app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

We have to refactor BT app to make sure it is embed-able from Settings app. 

We need this change because we don't want to maintain two similar codes between Settings app & BT app.

Comment 1

[[e-mail], [e-mail]]

Attachment: WIP 21390

A WIP for our refactor gaol. We can do following steps to make Bluetooth app running as an app from home screen.

* remove "type": "certified" from manifest
* add ["apps", "bluetooth"] in homescreen/build/default-homescreens.json
* add ["apps", "bluetooth"] in verticalhome/build/default-homescreens.json

Comment 2

[[e-mail], [e-mail]]

Per offline discussion for fixing embedded iframe issue, updated the WIP.

Comment 3

[[e-mail], [e-mail]]

Looks like that window.alert(), window.confirm(), window.prompt() not work in the embedded iframe. We keep to fix the issue in settings app.

Comment 4

[[e-mail], [e-mail]]

Comment on attachment 8450895 [details] [review]
WIP 21390

Hi Arthur, per offline discussion with porting issue, EJ have fixed window.xxx(); via bug 1033951. I think we could let the patch in reviewing state. Could you please help to review? Thanks.

Major change:

* Move Settings::bluetooth.js to Bluetooth app(rename with settings.js)
* Use settings key "bluetooth.device.connected" to maintain connected device
* Manifest change
* Will need to keep updating CSS style until we land the patch

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8450895 [details] [review]
WIP 21390

r=me with the nits addressed, thank you!

Comment 6

[[e-mail], [e-mail]]

Thanks for Arthur's reviewing effort. Since the pr is landed, we can close the issue now.

Gaia/master:  019669228af17bbd0e6001eacb33c80eb0a0ee29