[Flame]Missing bluetooth stack configuration files via full flash PVT image which causes bluetooth file transfer mal-function

RESOLVED FIXED in 2.0 S5 (4july)

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: shawnjohnjr, Assigned: shawnjohnjr)

Tracking

unspecified
2.0 S5 (4july)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:2.0+, b2g-v1.4 affected, b2g-v2.0 fixed, b2g-v2.1 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Missing bluetooth stack configuration files via full flash PVT images, which causes bluetooth file transfer fail to work.

STR:
1. Transfer files to another flames.
2. Connection fails to establish due to missing configuration.
Assignee: nobody → shuang
Created attachment 8448545 [details] [diff] [review]
bt-etc-files.patch
Attachment #8448545 - Flags: review?(vwang)
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
Summary: Missing bluetooth stack configuration files via full flash PVT image which causes bluetooth file transfer mal-function → [Flame]Missing bluetooth stack configuration files via full flash PVT image which causes bluetooth file transfer mal-function
blocking-b2g: --- → 2.0?
So many people complain about this. We have to put these configuration back.
Attachment #8448545 - Attachment is obsolete: true
Attachment #8448545 - Flags: review?(vwang)
/system/bluetooth/data/Android.mk seems no longer copy files now.
I found that
commit 1a441a6fa73b4de7d6d93564eb244a3232afc539
Author: Jean-Baptiste Queru <jbq@google.com>
Date:   Mon Sep 27 10:44:39 2010 -0700

    Separate smarthphone and nonsmartphone variants.
    
    Delete the makefile here, this is now handled by a
    PRODUCT_COPY_FILES in the base makefiles.

Comment 7

5 years ago
Comment on attachment 8450071 [details] [review]
Bug 1032088 - Add bluez configuration files (V2.0)

Not reviewing branch ports.
Attachment #8450071 - Flags: review?(mwu)

Updated

5 years ago
Attachment #8450074 - Flags: review?(mwu)

Comment 8

5 years ago
Do you really need a separate set of config files in the device directory? Is there some other path we can get these files from?
Can you accept the change in flame.mk without adding put duplicated files under device/t2m/flame?

+    system/bluetooth/data/main.conf:system/etc/bluetooth/main.conf \
+    system/bluetooth/data/input.conf:system/etc/bluetooth/input.conf \
+    system/bluetooth/data/blacklist.conf:system/etc/bluetooth/blacklist.conf \
+    system/bluetooth/data/network.conf:system/etc/bluetooth/network.conf \
+    system/bluetooth/data/audio.conf:system/etc/bluetooth/audio.conf \
+    system/bluetooth/data/auto_pairing.conf:system/etc/bluetooth/auto_pairing.conf \
That's fine.

Updated

5 years ago
Attachment #8450072 - Flags: review?(mwu) → review+
Comment on attachment 8450071 [details] [review]
Bug 1032088 - Add bluez configuration files (V2.0)

I don't review branch ports unless you believe it's so different that it needs to be looked again.
Attachment #8450071 - Flags: review?(mwu)

Updated

5 years ago
Attachment #8450074 - Flags: review?(mwu)
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/device-flame/commit/a928d2ae29244dfec3753ea695e6b98e38e8849a

Note that if you intend to land this on v1.4 as well, you'll want 1.4+ blocking status rather than 2.0.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-b2g-v1.4: --- → affected
status-b2g-v2.0: --- → affected
status-b2g-v2.1: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S5 (4july)
blocking-b2g: 2.0? → 2.0+
You need to log in before you can comment on or make changes to this bug.