10321 - Using the Exit menu causes Shutdown to get called twice.

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P2)

Description

[scottputterman]

If you use the Exit menu to quit Messenger, every nsIAppShellComponent's
Shutdown gets called twice.  This is because the implementation of Exit and main
call nsAppShellService::Shutdown.  What ends up happening is that the component
gets destroyed the first time and then gets recreated and destroyed again the
second time.  It seems wasteful if it can be avoided.

I've cc'd Steve and Paul because right now it looks like the XUL Overlay version
of Exit calls EditShell::Exit.  It seems stranger to be using the Editor's
implementation of Exit to shutdown Messenger, for example (even if at the moment
they would do the same thing).  I wonder if we need some other version of Exit?

Comment 1

[buster]

cc'ing Simon.  Simon, please work with Paul, Don, Scott to make this right.  Is
this a mail-specific problem, or do we have the same problem in ender itself?

Comment 2

[Simon Fraser [no longer active]]

Bill Law is working on the exit process, so should probably figure out what the
best thing is here.

Comment 3

[scottputterman]

This is not just a Messenger problem.  It's everywhere.  I just used Messenger
as an example because that's what I was testing.  I tried it from the Editor and
the components get Shutdown twice.

I cc'd the editor team because I noticed that your version of Exit is getting
used.  I just didn't think that seemed correct.

Comment 4

[hangas]

The owner of this bug should feel free to modify the globalOverlay.xul in such a

way as to be able to quit from any window in the application.  The current code

was copied from the messenger window's JavaScript.  This code will soon be

executed from the browser window as well.

Comment 5

[don]

Bill, how bad is this really?

Comment 6

[davidm]

Reassigning to me since I am working on shutdown. This will be real easy to fix.

Comment 7

[davidm]

Fix checked in. Broke shutdown into the Quit ui command and the shutdown cleanup
function. All quiting ( from the UI ) should use the command in globalOverlay.js

Comment 8

[cpratt]

Can't verify this (developer issue); taking davidm's word for it and marking it
verified.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a55c8d94a5b2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10321: Wire up play and pause buttons in tab tray (https://github.com/mozilla-mobile/fenix/pull/10422)