103213 - Inserting a character should not discontinue text styles

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[TucsonTester2]

Build ID: 20011003

If you insert a character or symbol into a line of text that has text styles
applied, then once you begin typing the text style will be discontinued.

Reproducible: Always

Steps to Reproduce:
1.Open composer
2.Click on the bold button on the toolbar and type some text
3.Click on insert -> Characters and Symbols
4.Choose a character, insert it, and close the window
5.Type some more text

Actual Results:
The bold style is discontinued.  The text style is preserved in NS 4.x.

Expected Results:
I would expect that the text style would be preserved.

Comment 1

[Syd Logan]

EDITORBASE bug, that shouldn't happen

Comment 2

[Charles Manske]

Joe: We're using nsHTMLEditor::InsertHTML to insert the character. Should that 
discontinue inline styles around the insert?

Comment 3

[Alex Vincent [:WeirdAl]]

confirmed Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.5+) Gecko/20011113

TucsonTester:  These are great testcases you're giving us, keep it up!!! :)

Comment 4

[Joe Francis]

InsertHTML() is indeed the culprit.  It's primary use is for paste, where we
decided to preserve the style (or non-style) of the inserted html and override
the style of the target document.

I will have to add an arg, or make a parallel api point for insertion that keeps
target style.

Comment 5

[TucsonTester1]

Text style does not continue after highlighting text and selecting a text style
beyond the first line.
Build ID: 2001120303

1.Open a blank page in the editor
2.Enter text then highlight
3.Change the style (Bold/Italic/Underline)
4.Insert cursor directly after that text
5.Enter more text/Verify that the new text retained the style selected
6.Deselect the text style and hit the enter key
7.Enter text then highlight
8.Change the style (Bold/Italic/Underline)
9.Insert cursor directly after that text
10.Enter more text

Actual Results:
The text style is discontinued on the second line of text.

Expected Results:
I would expect that the text style would be continued just as it did on the
first line in the body.

Note:
If you do not enter any text on the first line (just hit the enter key) you get
the same results - the text style does not continue.

Comment 6

[Syd Logan]

plussing

Comment 7

[Joe Francis]

I'm assuming TucsonTester1 meant to open a new bug against comment #5, rather
than placing it here.  opening bug 124805 for that.

Comment 8

[Joe Francis]

1.1

Comment 9

[Kevin McCluskey (gone)]

Bulk moving all nsbeta1+ bugs which were targetted after Mozilla1.0 to Mozilla1.0

Comment 10

[Joe Francis]

pri = 2 for original 1.0 EB+ bugs

Comment 11

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: patch v1.0

Am I totally out of sense of is this trivial one-liner patch the good answer
to the problem ? I tested the thing and it works just fine but I need Charley's

or Kathy's sharp eye to control it, thanks.

Comment 12

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

helping Kevin's queries with tag in summary line

Comment 13

[Kathleen :Brade]

Comment on attachment 78170 [details] [diff] [review]
patch v1.0

r=brade

Comment 14

[kinmoz]

Comment on attachment 78170 [details] [diff] [review]
patch v1.0

sr=[e-mail]

Comment 15

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 78170 [details] [diff] [review]
patch v1.0

a=[e-mail]

Comment 16

[Håkan Waara]

I need this fix, since my first name contain a 'å' character. I am willing to
check it in, everyone OK with this?

Comment 17

[Kevin McCluskey (gone)]

adt1.0.0

Comment 18

[Joe Francis]

Heh.  Daniel, as soon as you said you had a one liner, I knew what it had to be.  
:-)  Forest and Trees!

Comment 19

[Jaime Rodriguez, Jr.]

Removing adt1.0.0. Pls land this on the trunk, and let it bake for a couple of
days. If there are no regressions, and QA approves, pls renominate.

Comment 20

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Checked in into trunk, as requested. Sujay, could you please verify it ? thanks.

Comment 21

[michael wendell]

Verified on 04-11 trunk build.

Comment 22

[Kevin McCluskey (gone)]

adt1.0.0

Comment 23

[scottputterman]

marking adt1.0.0- and raising impact.  Let's look at this again for RTM.

Comment 24

[scottputterman]

adding adt1.0.0+.  Please get drivers approval again since it's been more than 3
days and then check into the 1.0 branch.

Comment 25

[scottputterman]

Adding adt1.0.1+ for adt approval for branch checkin for the 1.0.1 milestone. 
Please get drivers approval before checking in.

Comment 26

[Paul Wyskoczka]

marking adt1.0.1- per adt. This feature is not frequently used and there is a
work aroun.