1032172 - Replace use of getPrefSafe()

Status: RESOLVED INVALID

(Calendar :: Provider: GData, defect)

Description

[Mark Banner (:standard8)]

Seen on latest beta builds (TB 31.0b with Lightning 3.3b1):

[JavaScript Warning: "Use of getPrefSafe() is deprecated and will be removed with the next release. Use Preferences.get() instead.
1: [resource://calendar/modules/calUtils.jsm -> file:///Users/mark/Library/Thunderbird/Profiles/9uumlyqg.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calUtils.js:465] getPrefSafe
2: [resource://calendar/modules/calUtils.jsm -> file:///Users/mark/Library/Thunderbird/Profiles/9uumlyqg.default/extensions/%7Ba62ef8ec-5fdc-40c2-873c-223b8a6925cc%7D/js/calGoogleUtils.js:81] getCalendarPref
3: [resource://calendar/modules/calUtils.jsm -> file:///Users/mark/Library/Thunderbird/Profiles/9uumlyqg.default/extensions/%7Ba62ef8ec-5fdc-40c2-873c-223b8a6925cc%7D/js/calGoogleCalendar.js:144] cGC_findSession
4: [resource://calendar/modules/calUtils.jsm -> file:///Users/mark/Library/Thunderbird/Profiles/9uumlyqg.default/extensions/%7Ba62ef8ec-5fdc-40c2-873c-223b8a6925cc%7D/js/calGoogleCalendar.js:241] calGoogleCalendar.prototype.uri
5: [resource://calendar/modules/calUtils.jsm -> file:///Users/mark/Library/Thunderbird/Profiles/9uumlyqg.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calCalendarManager.js:442] cmgr_createCalendar
6: [resource://calendar/modules/calUtils.jsm -> file:///Users/mark/Library/Thunderbird/Profiles/9uumlyqg.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calCalendarManager.js:658] cmgr_assureCache
7: [resource://calendar/modules/calUtils.jsm -> file:///Users/mark/Library/Thunderbird/Profiles/9uumlyqg.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calCalendarManager.js:627] cmgr_getCalendars
8: [file:///Users/mark/Library/Thunderbird/Profiles/9uumlyqg.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/calCompositeCalendar.js:146] calCompositeCalendar.prototype.prefPrefix
9: [chrome://calendar/content/calUtils.js:1844] getCompositeCalendar
10: [chrome://calendar/content/calendar-task-tree.xml:132] calendar-task-tree_XBL_Constructor
"]

Comment 1

[Stefan Sitter [:ssitter]]

I don't see any calls to getPrefSafe() in Lightning source code: http://mxr.mozilla.org/comm-beta/search?string=getPrefSafe

I assume that you are using an old version of the Provider for Google Calendar extension that was not updated after the check-in for Bug 923026 on the mozilla30 branch.

Should be fixed by just releasing a current version of the Provider for Google Calendar extension.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Yes, I will be releasing a new version of the Provider with TB31. I might actually release the new-new provider from bug 493389. Thanks for the report though, I have the provider on my release checklist.