1032238 - Make some API functions work with Latin1 strings

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

Just some things on the JS side that I ran into last week.

Comment 1

[Luke Wagner [:luke]]

Comment on attachment 8448031 [details] [diff] [review]
Patch

Review of attachment 8448031 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsapi.cpp
@@ -5645,5 @@
>      if (!js_Stringify(cx, vp, replacer, space, sb))
>          return false;
> -    if (sb.empty()) {
> -        HandlePropertyName null = cx->names().null;
> -        return callback(null->chars(), null->length(), data);

I'm confused by this change; it seems unrelated to latin1.

Comment 2

[Jan de Mooij [:jandem]]

(In reply to Luke Wagner [:luke] from comment #1)
> I'm confused by this change; it seems unrelated to latin1.

The problem is that cx->names().null is a Latin1 string ("null"), so we can't call chars() on it and we have to inflate to pass it to the callback. There are a number of ways to fix this; the patch just appends it to the StringBuffer so that there's only one call to the callback function.

Comment 3

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5494989d182

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e5494989d182