Closed
Bug 1032343
Opened 10 years ago
Closed 10 years ago
Able to create task with end date prior to start date
Categories
(Mozilla QA Graveyard :: One and Done, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Milestone 2
People
(Reporter: rbillings, Assigned: impossibus)
References
()
Details
Attachments
(1 file)
Users are able to create tasks that end before they begin. There should be an error when selecting the date or after clicking Add Task.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → mjzffr
|
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8451014 -
Flags: review?(mozpankaj1994)
Attachment #8451014 -
Flags: review?(bob.silverberg)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8451014 [details] [review] Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/151 Goo start, Maja. Please address the comments in the PR and re-flag me for review.
Attachment #8451014 -
Flags: review?(bob.silverberg) → review-
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8451014 -
Attachment description: Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/151 → Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/151/files
Attachment #8451014 -
Flags: review- → review?(bob.silverberg)
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8451014 [details] [review] Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/151 Looks good, Maja. Please just add a unit test (or two) and it should be ready to merge.
Attachment #8451014 -
Flags: review?(bob.silverberg) → review-
|
|
Assignee | |
Comment 4•10 years ago
|
||
Comment on attachment 8451014 [details] [review] Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/151 I added some tentative tests to the PR and would like to check if I'm on the right track. (p.s. Not sure if I should be requesting review or feedback, Bob -- does it matter for your work flow?)
Attachment #8451014 -
Attachment description: Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/151/files → Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/151
Attachment #8451014 -
Flags: feedback?(bob.silverberg)
|
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8451014 [details] [review] Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/151 Looks good. Proceed with adding another test and refactoring the duplicate code. Thanks Maja.
Attachment #8451014 -
Flags: feedback?(bob.silverberg) → feedback+
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8451014 -
Flags: review- → review?(bob.silverberg)
|
|
||
Comment 6•10 years ago
|
||
Comment on attachment 8451014 [details] [review] Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/151 Just one teeny tiny change left.
Attachment #8451014 -
Flags: review?(bob.silverberg) → review-
|
|
Assignee | |
Comment 7•10 years ago
|
||
Comment on attachment 8451014 [details] [review] Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/151 Thanks, Bob. :) Teeny tiny change made, commits squashed.
Attachment #8451014 -
Flags: review- → review?(bob.silverberg)
|
|
||
Comment 8•10 years ago
|
||
Comment on attachment 8451014 [details] [review] Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/151 Landed in https://github.com/mozilla/oneanddone/commit/d1109e17586264f208516a19dcb83ee9df05b495
Attachment #8451014 -
Flags: review?(bob.silverberg) → review+
|
|
||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Attachment #8451014 -
Flags: review?(mozpankaj1994)
|
||
Updated•6 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•