Closed
Bug 1032389
Opened 11 years ago
Closed 11 years ago
Add JSON syntax for embedded TED and Popcorn videos
Categories
(Webmaker Graveyard :: Teaching Kits / Curriculum, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kat, Assigned: akirose)
References
Details
(Whiteboard: [resources][july25])
Attachments
(2 files, 1 obsolete file)
Currently (see this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1031582 ) I can easily embed Youtube and Vimeo videos into Webmaker "Resources" page JSON via Aki's https://github.com/gesa/webmaker.org/blob/1027273/video-embed/public/data/content.json#L2-L104 blob, but as discussed on IRC, we also will need syntax for:
* TED videos
* Popcorn videos
Thanks, Aki!
Updated•11 years ago
|
Assignee: nobody → aki
Assignee | ||
Comment 1•11 years ago
|
||
Adding this PR on my own fork right now because I don't want to merge the major syntax changes to content.json in Bug #1027273 until we've gotten through all of the file.
Attachment #8449819 -
Flags: review?(kate)
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Comment 2•11 years ago
|
||
Comment on attachment 8449819 [details] [review]
https://github.com/gesa/webmaker.org/pull/2
A few minor nits, this is looking awesome!
Attachment #8449819 -
Flags: review?(kate) → review+
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 3•11 years ago
|
||
Re-opening so I can get my branch from #1027273 merged.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 4•11 years ago
|
||
@codekat: just wanted to flag you here so you'd see the final PR on this mega-file being shepherded through.
Attachment #8449819 -
Attachment is obsolete: true
Attachment #8450661 -
Flags: review?(kate)
Attachment #8450661 -
Flags: feedback?(kat)
Updated•11 years ago
|
Attachment #8450661 -
Flags: review?(kate) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Merged!
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 6•11 years ago
|
||
Hey guys,
Have looked in JSON and looks like no short code for Popcorn videos to be embedded. Mind adding? Would be very useful for the first /resources page we put media to.
Thank you!
Flags: needinfo?(aki)
Assignee | ||
Comment 7•11 years ago
|
||
This is a good sample make to work with while figuring out how to make this magic happen: https://maxcapacity.makes.org/popcorn/1amp
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 8•11 years ago
|
||
Reopening this so we can be sure to add Popcorn video embeds when folks can get to it.
And at Aki's request, here are a few more details for further context:
* Bug for first page we add media to - "Composing" - https://bugzilla.mozilla.org/show_bug.cgi?id=1040953
* For example of where we'll need a Popcorn embed in the code, search Max Capacity in this text: https://bug1040953.bugzilla.mozilla.org/attachment.cgi?id=8458939
Comment 9•11 years ago
|
||
* Thanks Kat. Putting on [aug8] train.
* It's important that we be able to embed Popcorn videos on these pages. It's a great opportunity for us to showcase the tool.
Whiteboard: [resources][july11] → [resources][aug8]
Assignee | ||
Comment 10•11 years ago
|
||
Popcorn videos don't, like, have some sort of secret share/embed links I don't know about, do they? You keep talking about them like they're similarly packaged as youtube videos. I want to make sure I'm not missing something.
Flags: needinfo?(aki)
Assignee | ||
Comment 11•11 years ago
|
||
Attachment #8461786 -
Flags: review?(kate)
Updated•11 years ago
|
Attachment #8461786 -
Flags: review?(kate) → review+
Comment 12•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/webmaker.org
https://github.com/mozilla/webmaker.org/commit/206eb21668c49fab7491268575148ebf38c75aac
Fixes Bug 1032389 - Add JSON syntax for embedded TED and Popcorn videos
https://github.com/mozilla/webmaker.org/commit/b5719cab796addc48cb13bcff399cbfa98752f3a
Merge pull request #907 from gesa/1032389/popcorn-embeds
Fixes Bug 1032389 - Add JSON syntax for embedded TED and Popcorn videos
Updated•11 years ago
|
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Whiteboard: [resources][aug8] → [resources][july25]
Assignee | ||
Updated•11 years ago
|
Attachment #8450661 -
Flags: feedback?(kat)
You need to log in
before you can comment on or make changes to this bug.
Description
•