All users were logged out of Bugzilla on October 13th, 2018

xul file picker: Ctrl+click moves focus ring, but not highlight

VERIFIED FIXED in mozilla0.9.9

Status

P3
minor
VERIFIED FIXED
17 years ago
10 years ago

People

(Reporter: bugzilla, Assigned: janv)

Tracking

({polish})

Trunk
mozilla0.9.9
x86
All
polish

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
tested using 2001.10.04.08-trunk bits on linux.

1. open the file picker, ctrl+O or File > Open File.
2. click on an item to highlight it [it will also become the focused item].
3. hold down the Control key and click on another item in the dir list.

result: a focus ring appears on the item that you ctrl+clicked in step 3, even
though the highlight remains on the first item clicked in step 2.

notes:
* the actual item in focus is the one with the focus ring [step 3], since the
file picker goes to that dir [or open the file] when i hit the enter key.
* this isn't a problem when shift+clicking and alt+click [as expected :)].

occurs in both themes [not surprising]. attaching screenshot...
(Reporter)

Comment 1

17 years ago
in the upcoming screenshot, the highlighted item should actually be dark blue
--but gimp was the app in focus for the screenshot, hence the pale blue
highlight instead.
Keywords: mozilla0.9.7, polish
(Reporter)

Comment 2

17 years ago
Created attachment 52167 [details]
highlight: pale blue; focus ring consists of the two thin blue lines
Reassigning to Jan since he implemented the single-select mode for outliner.  I
think what we should do here is make shift+click and control+click work just
like a regular click if you are in single-select mode.
Assignee: bryner → varga
(Assignee)

Comment 4

17 years ago
Created attachment 67604 [details] [diff] [review]
fix
(Assignee)

Comment 5

17 years ago
bryner, review ?
Status: NEW → ASSIGNED
Keywords: mozilla0.9.7 → patch, review
Comment on attachment 67604 [details] [diff] [review]
fix

r=bryner
Attachment #67604 - Flags: review+
(Assignee)

Updated

17 years ago
OS: Linux → All
Priority: -- → P3
Target Milestone: --- → mozilla0.9.9

Comment 7

17 years ago
sr=hyatt
(Assignee)

Comment 8

17 years ago
fix checked in
(Assignee)

Comment 9

17 years ago
really fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 10

17 years ago
ctrl+click and shift+click now behave just like a regular single [left] click.
vrfy'd fixed using 2002.06.17.07 comm branch bits on linux.
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite

Updated

10 years ago
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.