103243 - xul file picker: Ctrl+click moves focus ring, but not highlight

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[sairuh (rarely reading bugmail)]

tested using 2001.10.04.08-trunk bits on linux.

1. open the file picker, ctrl+O or File > Open File.
2. click on an item to highlight it [it will also become the focused item].
3. hold down the Control key and click on another item in the dir list.

result: a focus ring appears on the item that you ctrl+clicked in step 3, even
though the highlight remains on the first item clicked in step 2.

notes:
* the actual item in focus is the one with the focus ring [step 3], since the
file picker goes to that dir [or open the file] when i hit the enter key.
* this isn't a problem when shift+clicking and alt+click [as expected :)].

occurs in both themes [not surprising]. attaching screenshot...

Comment 1

[sairuh (rarely reading bugmail)]

in the upcoming screenshot, the highlighted item should actually be dark blue
--but gimp was the app in focus for the screenshot, hence the pale blue
highlight instead.

Comment 2

[sairuh (rarely reading bugmail)]

Attachment: highlight: pale blue; focus ring consists of the two thin blue lines

Comment 3

[Brian Ryner (not reading)]

Reassigning to Jan since he implemented the single-select mode for outliner.  I
think what we should do here is make shift+click and control+click work just
like a regular click if you are in single-select mode.

Comment 4

[Jan Varga [:janv]]

Attachment: fix

Comment 5

[Jan Varga [:janv]]

bryner, review ?

Comment 6

[Brian Ryner (not reading)]

Comment on attachment 67604 [details] [diff] [review]
fix

r=bryner

Comment 7

[David Hyatt]

sr=hyatt

Comment 8

[Jan Varga [:janv]]

fix checked in

Comment 9

[Jan Varga [:janv]]

really fixed

Comment 10

[sairuh (rarely reading bugmail)]

ctrl+click and shift+click now behave just like a regular single [left] click.
vrfy'd fixed using 2002.06.17.07 comm branch bits on linux.