1032463 - href attribute isn't set for links in the "repos" menu, so unable to open repo X directly in new tab

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

1) Go to https://treeherder.mozilla.org/
2) Open the repos menu.
3) Middle mouse click one of the non-default repos (eg fx-team) to open in a new tab (or just use the context menu copy the URL)
4) Note the resultant URL

Expected:
https://treeherder.mozilla.org/ui/#/jobs?repo=fx-team

Actual:
https://treeherder.mozilla.org/ui/

This is because the href attribute isn't set:
<a href="" class="repo-link ng-binding" ng-click="changeRepo(repo.name)">fx-team</a>

Marking blocking since low hanging fruit, and given the issues discussed in bug 1032220, I'm using one tab per repo - so often need to load an additional tab for a new repo - and with this bug I have to open treeherder in another tab (which opens to the default repo) and then switch to the desired repo, which takes a lot longer.

Comment 1

[Cameron Dawson [:camd]]

Attachment: Pull request

Comment 2

[Cameron Dawson [:camd]]

https://github.com/mozilla/treeherder-ui/commit/4b48b341aa09519cd38dcd54ca535bc3a3b19e43

Comment 3

[Ed Morley [:emorley]]

Thank you - opening in a new tab works well, however I think the plus sign is maybe just a duplicate of the check box? I think without the plus sign the UX is still clear enough perhaps?

Comment 4

[Cameron Dawson [:camd]]

Ed-- Actually, the check box adds the repo as watched, but not load the resultsets, and leaves the window open.  The "+" sign will add it as watched, loads that repo's resultsets and closes the window.

So, without the "+" to switch to a new repo in the current window, you would check it, close the repo panel, and then click on the repo name in the top (black) bar.  

I'm fine to remove it if it just feels like clutter.  I just thought it would be convenient.  :)

Comment 5

[Ed Morley [:emorley]]

(In reply to Cameron Dawson [:camd] from comment #4)
> I'm fine to remove it if it just feels like clutter.  I just thought it
> would be convenient.  :)

Ah ok I see the difference now. I think the problem is that the UX isn't overly clear, so I fear it might be more confusing than helpful at the moment? Perhaps we can remove the plus signs and have another think in the future, once the other bugs are resolved :-)

Comment 6

[Cameron Dawson [:camd]]

Ed--  Yeah, good point.  OK.  I'll remove that.

Comment 7

[Cameron Dawson [:camd]]

This was removed in commit:
https://github.com/mozilla/treeherder-ui/commit/9c3cfc7b6e9fd47e13368cc2704cc9b66be2c39f

Comment 8

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/c4121dfd9229d1936893dc6a4dad4ad795f4cd6c
fix bug 1032463 - click repo link opens new tab
plus for add to watch and view, link opens new tab

https://github.com/mozilla/treeherder/commit/83bbbc7a4651a6fb6f049c7e0359c8681953f44a
Merge pull request #89 from mozilla/repo-link-new-tab

fix bug 1032463 - click repo link opens new tab