Closed Bug 1032469 Opened 7 years ago Closed 7 years ago

Update OpenTok library to 2.2.6

Categories

(Hello (Loop) :: Client, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla33

People

(Reporter: abr, Assigned: standard8)

References

Details

(Whiteboard: p=1 [qa-])

Attachments

(2 files, 1 obsolete file)

Attached file opentok-js-2.2.6.tgz
New library attached. Changes:

* HTTPS Default for logging
* MIT license in dynamic_config.js and ot.css
* unminified ot.css
* FFOS: 
    * Support for width/height/frameRate constraints with the new format implemented by Firefox
    * Support for facingMode constraint in getUserMedia
    * Be able to set the mozAudioChannelType = 'telephony' in the <video> tag of the publisher before the local stream is attached to it
* Delay allow/Deny UI for 5 seconds of inactivity in Chrome
* Better logging of peer connection errors
* QOS logging of publisher/subscriber size
* Allow OT.properties to be defined before opentok.js loads. Properties that you can overwrite:
    window.OTProperties.cdnURL
    window.OTProperties.configURL
    window.OTProperties.assetURL
    window.OTProperties.cssURL
Priority: -- → P1
Target Milestone: --- → mozilla33
Whiteboard: p=1
Attached patch Update to 2.2.6 (obsolete) — Splinter Review
This updates to 2.2.6. I've handled the new window.OTProperties items, so there's no changes to the sdk file itself.

Note that dynamic_config is now minified again - maybe we should be getting the non '.min.' version from the filename.

I've also taken the opportunity to rename the directories to something slightly shorter and drop the version numbers from the directory name. I think this is reasonable, as the sdk version is detailed in the sdk file.
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Attachment #8450905 - Flags: review?(adam)
Attachment #8450905 - Flags: review?(adam) → review+
sorry had to back this change out for test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=43327028&tree=Mozilla-Inbound
So when I moved the files I forgot about the whitelist for this test. This versions adds updating the whitelist to keep the test passing.
Attachment #8450905 - Attachment is obsolete: true
Attachment #8452273 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8452273 [details] [diff] [review]
Update to 2.2.6 v2

Review of attachment 8452273 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/general/browser_parsable_css.js
@@ +14,4 @@
>    {sourceName: /codemirror\.css/i}, /* CodeMirror is imported as-is, see bug 1004423 */
>    {sourceName: /web\/viewer\.css/i, errorMessage: /Unknown pseudo-class.*(fullscreen|selection)/i }, /* PDFjs is futureproofing its pseudoselectors, and those rules are dropped. */
>    {sourceName: /aboutaccounts\/(main|normalize)\.css/i}, /* Tracked in bug 1004428 */
> +  {sourceName: /loop\/.*\/sdk-content\/.*\.css$/i /* TokBox SDK assets, see bug 1032469 */}

You just renamed this, right? rs=me on the test change. :-)
Attachment #8452273 - Flags: review?(gijskruitbosch+bugs) → review+
(In reply to :Gijs Kruitbosch from comment #5)
> You just renamed this, right? rs=me on the test change. :-)

Yes, thanks.

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b8883e3b8b8
QA Contact: anthony.s.hughes
Whiteboard: p=1 → p=1 [qa-]
You need to log in before you can comment on or make changes to this bug.