Closed Bug 1032514 Opened 10 years ago Closed 10 years ago

tab left after a failed test can cascade into hundred other failed tests

Categories

(Add-on SDK Graveyard :: General, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla34

People

(Reporter: zombie, Assigned: zombie)

Details

Attachments

(1 file)

there are only two (four) tests that actually failed in this try run: https://tbpl.mozilla.org/php/getParsedLog.php?id=42793084&tree=Jetpack but due to bug 863456, it looks like all the tests after test-page-mod:testContentScriptWhenOnTabReady fail. if a tab was left open after a test in test-addon-installer.js, i think all the other tests would be reported as failing. this is less than optimal..
Can we just close a tab if it's found in a place it shouldn't be to stop it from cascading through everything?
Priority: -- → P2
(In reply to Wes Kocher (:KWierso) from comment #1) > Can we just close a tab if it's found in a place it shouldn't be to stop it > from cascading through everything? yes! that turned out to be even simpler..
Assignee: nobody → tomica+amo
Status: NEW → ASSIGNED
Attachment #8459618 - Flags: review?(dtownsend+bugmail)
Attachment #8459618 - Flags: review?(dtownsend+bugmail) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/24e4a46440a5e4ab43270c43fd03d4c0f1eb75d0 bug 1032514 - close leftover tabs after each test https://github.com/mozilla/addon-sdk/commit/5beb920d33dba38a4c733fa8a0ecbafec8847399 Merge pull request #1558 from zombie/1032514-tabs-left bug 1032514 - close leftover tabs after each test, r=@Mossop
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: