Closed Bug 1032530 Opened 10 years ago Closed 10 years ago

mach mochitest commands should take --setpref argument like runtests.py does

Categories

(Testing :: Mochitest, defect)

Product:
Testing
Component:
Mochitest
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla33

People

(Reporter: dbaron, Assigned: agi)

Details

Attachments

(1 file)

mach mochitest takes --setpref argument
3.22 KB, patch
gps
: review+
Details | Diff | Splinter Review 
The mach mochitest commands should have a --setpref argument like mochitest runtests.py does (or like mach reftest comands do).

(I'm not planning to patch this since I don't follow all the python magic right now; it's easier to just modify greprefs.js.)
Component: Build Config → Mochitest
Product: Core → Testing
I think this should do. dbaron do you know who I can ask for review for this patch? I'm new in this component :) Thanks!
Flags: needinfo?(dbaron)
Attachment #8455031 - Flags: review?(gps)
Comment on attachment 8455031 [details] [diff] [review]
mach mochitest takes --setpref argument

Review of attachment 8455031 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

I assume you tested this.
Attachment #8455031 - Flags: review?(gps) → review+
If you have in fact tested this, you should add the checkin-needed keyword.
Flags: needinfo?(agi.novanta)
Yup. I was planning on doing a little bit more of testing tonight before asking to check-in the code. Sorry that was probably unclear.
Flags: needinfo?(agi.novanta)
Everything seems to work!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/816b270f3a2e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: