1032537 - Marketplace results in Rocketbar do not have round icons

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Andrew Stole [:astole]]

Attachment: logcat

When searching for apps through the E.me search bar, the markeplace results that are populated are square icons which is inconsistent with the E.me icons which are round.

Repro Steps:
1) Update a Flame to BuildID: 20140630000201
2) Tap on the E.me search bar
3) Search for an app (ex. Facebook)

Actual:
Marketplace result icon is not round

Expected:
All icons are rounded in the e.me search results

2.0 Environmental Variables:
Device: Flame 2.0
BuildID: 20140630000201
Gaia: c0c8ad187c0466285f2580531e09f8322996f561
Gecko: d4dc609bcc8a
Version: 32.0a2
Firmware Version: v122

Repro frequency: 2/2, 100%
See attached: Screenshot, logcat

Comment 1

[Andrew Stole [:astole]]

Adding qawanted to check other devices and builds.

Comment 2

[Andrew Stole [:astole]]

Attachment: Screenshot

Attaching screenshot of Facebook icon in e.me search results.

Comment 3

[Peter Bylenga [:PBylenga]]

Let's get some branch checks to see if this is a regression or not.

Comment 4

[Cody Roesch [:croesch]]

This bug repro's on: Flame 2.1 Master, Flame 2.0, Flame 1.4, Buri 2.1

Actual Results: Some E.me results are showing up as square instead of round. In Flame 1.4, the square facebook icon can only be seen if "faceboo" instead of "facebook" is typed into e.me.

Environmental Variables:
Device: Flame Master
Build ID: 20140630183300
Gaia: 90bb898e8401f5fb98edcf38293073c5c26ab7bd
Gecko: 83c09fe3a658
Version: 33.0a1 (Master)
Firmware Version: v122
-----------------------------------------------
Environmental Variables:
Device: Flame 2.0
Build ID: 20140630213715
Gaia: 8fb5e2a9ad1025ee7d247b90af7499766afadd28
Gecko: 5da69a493324
Version: 32.0a2 (2.0)
Firmware Version: v122
-----------------------------------------------
Environmental Variables:
Device: Flame 1.4
Build ID: 20140630000201
Gaia: aa896d5db1b4929f3bf31a0f4bb7de50530222a8
Gecko: 8cba60bc12ef
Version: 30.0 (1.4)
Firmware Version: v122
-----------------------------------------------
Environmental Variables:
Device: Buri Master
Build ID: 20140630183300
Gaia: 90bb898e8401f5fb98edcf38293073c5c26ab7bd
Gecko: 83c09fe3a658
Version: 33.0a1 (Master)
Firmware Version: v1.2device.cfg

Comment 5

[Joshua Mitchell (Inactive)]

Not a Regression

Comment 6

[Peter Bylenga [:PBylenga]]

Requesting input from UX on the expected behavior for Marketplace results in E.Me searches to determine if this should block.

Comment 7

[Stephany Wilkes]

Flagging Amy on the icon issue and Francis on expected search results, though I'm not sure these are actually two separate issues.

Comment 8

[Francis Djabri [:djabber]]

I'm not sure if we can do anything about the market place icons not being round, but all e.me results should be round. Also NI? Eric for comment.

Comment 9

[Eric Pang [:epang] UX]

There's most likely nothing we can do for the market place icons - in our style guide we allow for round or square icons.  On a side now I'm concerned about the blurriness of the Facebook icon.

Like Francis said all e.me icons should be round.

Comment 10

[Amy Lee [:amylee] UX]

(In reply to Stephany Wilkes from comment #7)
> Flagging Amy on the icon issue and Francis on expected search results,
> though I'm not sure these are actually two separate issues.

I second Eric's comment. We also have round and square icons on homescreen (native app icons/marketplace app icons).

Comment 11

[Amir Nissim (:amirn)]

E.me does not provide marketplace results starting with v2.0

Comment 12

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

if icons are not coming from e.me, should it be round still?  Or is it ok as is?

Comment 13

[Eric Pang [:epang] UX]

Ideally we would have round icons, but if not possible it's okay as is.  Thanks Naoki!

Comment 14

[Dale Harvey (:daleharvey)]

We shouldnt be changing applications icons just because that screen used to mostly be round icons, closing out